Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the Importing of a world #149

Merged
merged 14 commits into from
Dec 31, 2024
Merged

Optimize the Importing of a world #149

merged 14 commits into from
Dec 31, 2024

Conversation

0xnim
Copy link
Contributor

@0xnim 0xnim commented Dec 30, 2024

No description provided.

@0xnim 0xnim marked this pull request as ready for review December 30, 2024 23:59
ReCore-sys
ReCore-sys requested changes Dec 31, 2024
View reviewed changes
Copy link
Collaborator

@ReCore-sys ReCore-sys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic is sound, could do with some performance tune ups

src/lib/storage/src/lmdb.rs Show resolved Hide resolved
src/lib/world/src/importing.rs Show resolved Hide resolved
src/lib/world/src/db_functions.rs Show resolved Hide resolved
src/lib/world/src/importing.rs Show resolved Hide resolved
@ReCore-sys ReCore-sys merged commit 5e27c5c into ferrumc-rs:master Dec 31, 2024
9 checks passed
@0xnim
Copy link
Contributor Author

0xnim commented Dec 31, 2024

ty

@0xnim 0xnim deleted the import_optimize branch December 31, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radstevee radstevee radstevee approved these changes

@ReCore-sys ReCore-sys ReCore-sys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xnim @ReCore-sys @radstevee