Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linting errors #340

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Fix linting errors #340

merged 1 commit into from
Jan 23, 2024

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented Jan 23, 2024

Fixes some Standard linting errors that was introduced in #303

@LinusU LinusU mentioned this pull request Jan 23, 2024
Merged
@junderw
Copy link
Contributor

junderw commented Jan 23, 2024 •
edited
Loading

This lint failed because it was added to standard after I made the PR years ago, and standard is using "*" as the version in package.json

Edit: nvm, I wasn't the one that wrote the constant table. It was added right before merging.

@LinusU
Copy link
Contributor Author

LinusU commented Jan 23, 2024

(failing CI adressed in #342)

@dcousens dcousens merged commit 56a89eb into feross:master Jan 23, 2024
2 of 6 checks passed
@dcousens
Copy link
Collaborator

Thansk @LinusU

@LinusU LinusU deleted the lu-fix branch January 23, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcousens dcousens dcousens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LinusU @junderw @dcousens