Request ID #2411
Closed
Request ID #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am curious if this would be needed once we have wasi-observe and otel? |
|
@karthik2804 on that I was guided by #2146 (comment) but for sure I do not know enough either way |
|
Could this (also?) be a Spin variable? |
|
I think this may in fact be best served via wasi-observe. Distributed traces are typically keyed off of a trace ID which is either passed in via e.g. W3C Trace Context or generated by the server (if it is the first hop in the traced system). That trace ID could be emitted with logs and - if necessary - exposed to the guest via a wasi-observe import. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible approach to #2146 but I feel kinda queasy using an environment variable instead of an API but maybe that's just me