Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use favicons instead of icons #1734

Merged
merged 1 commit into from
May 3, 2024

Conversation

SpecialAro
Copy link
Member

@SpecialAro SpecialAro commented May 3, 2024

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Add ability to use favicons instead of default/custom icons

Motivation and Context

This fixes #1340 and fixes #257.

Issue #257 also refers:

Additionally, will be good to allow paste url of icon, additionally to current ability to upload the icon from local filesystem, because most of favicons are available via url, so we'll can get rid of the "File » Save as + Upload to Ferdium" ritual :)

This is NOT included in this PR.

This PR makes use of the Google API for favicons (https://www.google.com/s2/favicons as stated in src/helpers/favicon-helpers.ts) - let me know if there is any issue on using this.

Screenshots

Without favicon With favicon
image image

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

Added ability to use favicons instead of default/custom icons (on edit service menu)

@SpecialAro SpecialAro requested a review from a team May 3, 2024 00:11
@SpecialAro SpecialAro self-assigned this May 3, 2024
Copy link
Contributor

@vraravam vraravam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works great (tested locally)

@vraravam vraravam merged commit 6c9475c into ferdium:develop May 3, 2024
5 checks passed
@SpecialAro SpecialAro deleted the add-favicons branch May 3, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use website's favicon instead of service icon? Feature: Auto download icon for "Custom website" service
2 participants