Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tippecanoe-overzoom accept filters from a file #307

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Make tippecanoe-overzoom accept filters from a file #307

merged 5 commits into from
Dec 5, 2024

Conversation

e-n-f
Copy link
Collaborator

@e-n-f e-n-f commented Dec 5, 2024 •
edited
Loading

Adds --feature-filter-file and --clip-polygon-file options to tippecanoe-overzoom, to support longer expression and spatial filters than can be passed as command line arguments.

@e-n-f e-n-f marked this pull request as ready for review December 5, 2024 19:22
ChrisLoer
ChrisLoer approved these changes Dec 5, 2024
View reviewed changes
Copy link

@ChrisLoer ChrisLoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a brief sanity check in Felt that this allows us to avoid the limits we were hitting before.

@e-n-f e-n-f merged commit bdfb06c into main Dec 5, 2024
4 checks passed
@e-n-f e-n-f deleted the overzoom-filters-from-file branch December 5, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisLoer ChrisLoer ChrisLoer approved these changes

@migurski migurski Awaiting requested review from migurski

@arredond arredond Awaiting requested review from arredond arredond is a code owner

@dnomadb dnomadb Awaiting requested review from dnomadb dnomadb is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-n-f @ChrisLoer