Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another round of binning fixes #274

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Another round of binning fixes #274

merged 5 commits into from
Sep 30, 2024

Conversation

e-n-f
Copy link
Collaborator

@e-n-f e-n-f commented Sep 28, 2024 •
edited
Loading

If a point fails to match any pnpoly test when binning, assign it to the bin closest to it in geographic sequence.

@e-n-f e-n-f marked this pull request as ready for review September 30, 2024 06:30
ChrisLoer
ChrisLoer approved these changes Sep 30, 2024
View reviewed changes
Copy link

@ChrisLoer ChrisLoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think you're doing this on "hard mode" by trying to work with geometry instead of the bin index, but this is a great improvement in the maps I've tested.

@e-n-f e-n-f merged commit 66e5d66 into main Sep 30, 2024
4 checks passed
@e-n-f e-n-f deleted the bin-buffer branch September 30, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisLoer ChrisLoer ChrisLoer approved these changes

@migurski migurski Awaiting requested review from migurski

@arredond arredond Awaiting requested review from arredond arredond is a code owner

@dnomadb dnomadb Awaiting requested review from dnomadb dnomadb is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-n-f @ChrisLoer