Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specific "paid plan required" error message #93

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

ChrisLoer
Copy link
Contributor

@ChrisLoer ChrisLoer commented Jan 14, 2025

Since Felt changed to requiring a paid plan for all data uploads, QGIS users on free accounts have been receiving a very generic "an error occurred" message when they try to upload and get a 403.

This PR watches for 403's and reports a specific error message.

Test plan:

  • Install the new plugin from the zip
  • Upload layers from a map using a paid workspace, make sure it works as before
  • Upload layers from using a free-plan workspace, verify that you get the new more-informative error message.

…te the user is authorized but needs a paid plan.
Copy link

github-actions bot commented Jan 14, 2025

Plugin ready!

A test version of this PR is available for testing here.

(Built from commit c673606)

@ChrisLoer ChrisLoer requested a review from drewhgood January 14, 2025 02:26
@ChrisLoer ChrisLoer marked this pull request as ready for review January 14, 2025 02:26
Copy link

@drewhgood drewhgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to upload a layer from QGIS with a paid plan. When I tried with a free one I saw the new error message. The link to pricing and mailto links work as expected.

Code changes look correct.

Screenshot 2025-01-14 at 9 00 20 AM

@ChrisLoer ChrisLoer merged commit b61a4d5 into main Jan 14, 2025
17 checks passed
@ChrisLoer ChrisLoer deleted the cloer/paid_plan_error branch January 14, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants