Forward all presigned_attributes instead of trying to choose which ones to forward #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelson
approved these changes
Oct 16, 2024
| 'x-amz-meta-file-count': self.x_amz_meta_file_count, | ||
| 'x-amz-security-token': self.x_amz_security_token, | ||
| } | ||
| return {**self._presigned_attributes} |
There was a problem hiding this comment.
Is this guaranteed to preserve the order of attributes that we received from the server? If the ordering changes then the signature will be invalid.
There was a problem hiding this comment.
yeah it should preserve order although it would be nice if it were spelled out more explicitly. I added a comment at least.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the switch to multi-region hosting, uploads from the QGIS plugin broke because we had to change some of the presigned attribute signature keys (specifically adding
x-amz-signature). The expectation was that API callers would forward all presigned attributes, but the QGIS plugin tried to pick and choose the ones it thought were necessary. This change just tries to forward the whole block.We're going to fix this here in the plugin, but we're simultaneously trying to build in some backwards compatibility on the Felt pipeline side so that people with un-upgraded plugins can still upload files (as long as they're talking to the us1 Felt region, which until this week, everyone was)
Test plan: