Adjust the copy in the auth dialog to remove commas #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses https://github.com/felt/qgis-plugin-discussion/issues/25 by removing commas that do not display correctly on MacOS.
nyalldawson
approved these changes
Feb 28, 2024
|
Thanks for the ✅ @nyalldawson! I noticed this failed on CI, so before merging I started working on a fix for the CI job, see #61. |
|
Okay, CI is passing now, so I'll plan to merge this soon. @nyalldawson how about this one goes into a 2.0.1 milestone? (which could be this and any other small fixes that come up soon) and then additional new features could go into a 3.0.0 milestone - let me know if that sounds good to you. |
|
@springmeyer fine by me. Want me to push 2.0.1 now? |
👍🏼 sounds great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the commas in the text used on the Auth dialog do not render correctly on MacOS machines using the official (intel-based) Qgis 3.34 installer from https://www.qgis.org/en/site/forusers/download.html.
Current:
Expected:
This addresses the issue by simplifying the language to avoid needing commas.