coverage

felangel · Apr 2, 2024 · 821ffb6 · 821ffb6
1 parent ce11a74
commit 821ffb6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/lib/flow_builder.dart b/lib/flow_builder.dart
@@ -178,7 +178,6 @@ class _FlowBuilderState<T> extends State<FlowBuilder<T>> {
       controller: _controller,
       child: _ConditionalPopScope(
         condition: _canPop,
-        onPopInvoked: (bool _) => _navigator?.maybePop(),
         child: Navigator(
           key: _navigatorKey,
           pages: _pages,
@@ -330,23 +329,15 @@ class FakeFlowController<T> extends FlowController<T> {
 class _ConditionalPopScope extends StatelessWidget {
   const _ConditionalPopScope({
     required this.condition,
-    required this.onPopInvoked,
     required this.child,
   });
 
   final bool condition;
   final Widget child;
-  final PopInvokedCallback onPopInvoked;
 
   @override
   Widget build(BuildContext context) {
-    return condition
-        ? PopScope(
-            canPop: false,
-            onPopInvoked: onPopInvoked,
-            child: child,
-          )
-        : child;
+    return condition ? PopScope(canPop: false, child: child) : child;
   }
 }
 

diff --git a/test/flow_builder_test.dart b/test/flow_builder_test.dart
@@ -1388,7 +1388,7 @@ void main() {
       expect(navigators.last.observers, equals(observers));
     });
 
-    testWidgets('SystemNavigator.pop respects when PopScope(canPop: false)',
+    testWidgets('SystemNavigator.pop respects PopScope(canPop: false)',
         (tester) async {
       const targetKey = Key('__target__');
       var onPopCallCount = 0;
@@ -1442,7 +1442,7 @@ void main() {
       expect(find.byKey(targetKey), findsOneWidget);
     });
 
-    testWidgets('SystemNavigator.pop respects when PopScope(canPop: true)',
+    testWidgets('SystemNavigator.pop respects PopScope(canPop: true)',
         (tester) async {
       const targetKey = Key('__target__');
       var onPopCallCount = 0;