allow callback for field properties, improve MetaMixin for WebPage doc #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiask
approved these changes
Nov 16, 2023
feincms3_meta/fields.py
Outdated
| super().__init__(property, *args, **kwargs) | ||
|
|
||
| def contribute_to_class(self, cls, name): | ||
| self.field.contribute_to_class(cls, name) | ||
| self.value = lambda obj: ( | ||
| self.value = lambda obj: self.callback( |
There was a problem hiding this comment.
Hmm, das ist eher eine Art coerce Funktion, oder? https://github.com/matthiask/speckenv/blob/49dd513950b7cce09767805411baeccb0a3ab0b5/speckenv.py#L54
Wärs alternativ etwas flexibler, wenn der Callback das ganze Objekt erhält, und nicht nur den Wert des Attributs? Dann würde value=lambda obj: obj.image.opengraph if obj.image else "" funktionieren.
Und dann könnte auch der Fallback so gelöst werden, zB value=lambda obj: obj.name or obj.fallback?
There was a problem hiding this comment.
Gute Idee, ich versuchs mal.
coerce ✅
|
Merci! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.