Fixed use of setInboxDispatcher after setInboxListeners
#101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.11-maintenance #101 +/- ##
===================================================
Coverage ? 80.30%
===================================================
Files ? 40
Lines ? 5931
Branches ? 709
===================================================
Hits ? 4763
Misses ? 1155
Partials ? 13 ☔ View full report in Codecov by Sentry. |
There is a bug where setting the inbox dispatcher after the listeners causes an error to be thrown due to path mismatch.
This fixes the issue with path mismatch when calling `setInboxDispatcher`
dahlia
reviewed
Jul 15, 2024
dahlia
force-pushed
the
fix-inbox-path-check
branch
from
5331496 to
4bb32dc
Compare
dahlia
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug where setting the inbox dispatcher after the listeners causes an error to be thrown due to path mismatch.