operator tls review fix: if statement

Signed-off-by: Tommy Hughes <[email protected]>
feast-dev · Dec 1, 2024 · 61a0a96 · 61a0a96
1 parent b72cdac
commit 61a0a96
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/infra/feast-operator/internal/controller/services/services.go b/infra/feast-operator/internal/controller/services/services.go
@@ -40,12 +40,14 @@ func (feast *FeastServices) Deploy() error {
 	if err := feast.ApplyDefaults(); err != nil {
 		return err
 	}
-	if openshiftTls, err := feast.checkOpenshiftTls(); openshiftTls {
+	openshiftTls, err := feast.checkOpenshiftTls()
+	if err != nil {
+		return err
+	}
+	if openshiftTls {
 		if err := feast.createCaConfigMap(); err != nil {
 			return err
 		}
-	} else if err != nil {
-		return err
 	} else {
 		_ = feast.deleteOwnedFeastObj(feast.initCaConfigMap())
 	}