This repository has been archived by the owner on Jan 1, 2025. It is now read-only.
Labqurzor App #112
Open
Labqurzor App #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Solving fbsamples#38 By converting all of the locales to unix files. Pull Request resolved: fbsamples#39 Reviewed By: virtuallyawake Differential Revision: D17494068 Pulled By: jorgeluiso fbshipit-source-id: 676e929988eec80b20ed5f8db0c414b85d7e9f5d
Summary: #### Is your pull request related to a problem? Please describe This solves fbsamples#37 Pull Request resolved: fbsamples#40 Test Plan: Uploaded this branch to my staging server `git push -f staging fix-es-menu-lenght:master` Deleted my stagin messenger profile ``` curl -X DELETE \ 'https://graph.facebook.com/v4.0/me/messenger_profile?fields=[%22get_started%22,%22greeting%22,%22persistent_menu%22]' \ -H 'Authorization: Bearer XXXXXX' ``` Verified it was empty ``` curl -X GET \ 'https://graph.facebook.com/v4.0/me/messenger_profile?fields=get_started,greeting,persistent_menu' \ -H 'Authorization: Bearer XXXXXX' \ ``` Set the profile from my staging `https://xxxxxx.herokuapp.com/profile?mode=all&verify_token=xxxxxxxx` Verified it was set for locales: ["en_US", "fr_FR", "es_ES", "es_LA", "pt_BR", "id_ID"], ``` curl -X GET \ 'https://graph.facebook.com/v4.0/me/messenger_profile?fields=get_started,greeting,persistent_menu' \ -H 'Authorization: Bearer XXXXXX' \ ``` #### Checklist - [Y] My code follows the code style of this project. - [N] My change requires a change to the documentation. - [N] I have updated the documentation accordingly. - [Y] I have read the **[CONTRIBUTING](https://github.com/fbsamples/original-coast-clothing/blob/master/CONTRIBUTING.md)** document. - [Y] I have added tests to cover my changes. - [Y] All new and existing tests passed. - [Y] The title of my pull request is a short description of the requested changes. - [Y] I have added jorgeluiso, rubycalling as reviewers. - [N] I have added the label **enhancement** to my pull request. Reviewed By: virtuallyawake Differential Revision: D17494069 Pulled By: jorgeluiso fbshipit-source-id: 217ea5208208132b8865273abdca01cf3d14fbbf
Summary: #### Is your pull request related to a problem? Please describe This solves fbsamples#41 #### Describe the solution you'd like Fixing the reference to the available languages in the i18n configuration. Pull Request resolved: fbsamples#42 Test Plan: Deleted my staging messenger profile ``` curl -X DELETE \ 'https://graph.facebook.com/v4.0/me/messenger_profile?fields=[%22get_started%22,%22greeting%22,%22persistent_menu%22]' \ -H 'Authorization: Bearer XXXXXX' ``` Verified it was empty ``` curl -X GET \ 'https://graph.facebook.com/v4.0/me/messenger_profile?fields=get_started,greeting,persistent_menu' \ -H 'Authorization: Bearer XXXXXX' \ ``` Set the profile from my staging ``` https://xxxxxx.herokuapp.com/profile?mode=all&verify_token=xxxxxxxx ``` Query the messenger profile ``` curl -X GET \ 'https://graph.facebook.com/v4.0/me/messenger_profile?fields=get_started,greeting,persistent_menu' \ -H 'Authorization: Bearer XXXXXX' \ ``` Verified it was set for locales: [ "en_US", "fr_FR", "es_ES", "es_LA", "pt_BR", "id_ID", "ar_AR", "de_DE", "it_IT", "ja_JP", "ko_KR", "ru_RU", "th_TH", "vi_VN", "zh_CN", "zh_HK", "zh_TW" ], Reviewed By: virtuallyawake Differential Revision: D17494071 Pulled By: jorgeluiso fbshipit-source-id: e44bfc747747353559f4135f1956782b6da174b6
Summary: Add Private Reply feature to Original Coast Clothing sample bot We will support both comment and post in the page to trigger private reply Reviewed By: jorgeluiso Differential Revision: D17861118 fbshipit-source-id: fd96e581b40fa45b0a7621cbcbf45d97efb0edaf
fbsamples#49) Summary: Removing the line: - [ ] I have added jorgeluiso, rubycalling as reviewers. This causes unnecessary mentions to our user names on project forks. Pull Request resolved: fbsamples#49 Reviewed By: Riandy Differential Revision: D18031278 Pulled By: jorgeluiso fbshipit-source-id: f2e2e95c97fa98d54de27f0f1c36a5c726627559
Summary: Pull Request resolved: fbsamples#62 as per title Reviewed By: jorgeluiso Differential Revision: D22124858 fbshipit-source-id: fb7778a66f8b04e0f7375b40d216010b2daa4490
Summary: Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br /> [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/fbsamples/original-coast-clothing/network/alerts). </details> Pull Request resolved: fbsamples#63 Reviewed By: rubycalling Differential Revision: D25585766 Pulled By: Barbog fbshipit-source-id: 73af330d381b132aad579b8c81fe643247657577
Summary: #### Is your pull request related to a problem? Please describe Travis CI is being deprecated but we want to retain the capacity to lint any new code — adding GitHub actions to replace it. #### Describe the solution you'd like Replace Travis CI with GitHub Actions #### Describe alternatives you've considered Also considered CircleCI , but determined that the integration with GitHub Actions was cleaner and the config file simpler. #### Additional context Add any other context or screenshots about the feature request here. Pull Request resolved: fbsamples#69 Test Plan: A good test plan should give instructions that someone else can easily follow. Also add a link to your own Messenger experience for your reviewer to test the changes. #### Checklist - [{emoji:2714} ] My code follows the code style of this project. - [{emoji:2716} ] My change requires a change to the documentation. - [{emoji:2714} ] I have updated the documentation accordingly. - [{emoji:2714} ] I have read the **[CONTRIBUTING](https://github.com/fbsamples/original-coast-clothing/blob/master/CONTRIBUTING.md)** document. - [{emoji:2716} ] I have added tests to cover my changes. - [ n/a ] All new and existing tests passed. - [{emoji:2714} ] The title of my pull request is a short description of the requested changes. - [{emoji:2714} ] I have added the label **enhancement** to my pull request. Reviewed By: rubycalling Differential Revision: D25678411 Pulled By: Barbog fbshipit-source-id: 85ef7ad593a5c36d8627404813d0ecdfe343e9db
Summary: There were files missing the FB copyright notices. #### Is your pull request related to a problem? Please describe The javascript style will include the header once in the client script, while the EJS style of <% /* %> will hide it — thus ensuring that it is displayed only once to someone inspecting the source. #### Describe the solution you'd like Ensure that each file has copyright notices, and that the main app script shipped to web clients have it declared exactly once at the the top #### Describe alternatives you've considered using only ejs-styled comments so as to not display the copyright notice to the webclient — but it _may_ be a legal requirement to have it shown at least once. Pull Request resolved: fbsamples#70 Test Plan: The internal validation tool should stop complaining about missing copyright notices #### Checklist - [{emoji:2714} ] My code follows the code style of this project. - [X] My change requires a change to the documentation. - [{emoji:2714} ] I have updated the documentation accordingly. - [{emoji:2714} ] I have read the **[CONTRIBUTING](https://github.com/fbsamples/original-coast-clothing/blob/master/CONTRIBUTING.md)** document. - [n/a] I have added tests to cover my changes. - [n/a] All new and existing tests passed. - [{emoji:2714} ] The title of my pull request is a short description of the requested changes. - [n/a] I have added the label **enhancement** to my pull request. Reviewed By: rubycalling Differential Revision: D25692479 Pulled By: Barbog fbshipit-source-id: a7af7c39e6e915777433194b19d05e645c0ff8d9
…samples#73) Summary: to remove vulnerabilities present in minimist, updated packages: * i18n * eslint tested by deploying to Heroku and testing features. i18n features still functioned as expected #### Is your pull request related to a problem? Please describe This addresses the current vulnerabilities in the currently used minimist packages * https://nvd.nist.gov/vuln/detail/CVE-2020-7598 * GHSA-vh95-rmgr-6w4m #### Describe the solution you'd like Updates the packages dependent on minimist to update the vulnerable package Pull Request resolved: fbsamples#73 Test Plan: Installed in Heroku, hooked up to a Messenger app, trialed the functionality of modified packages (notably i18n) #### Checklist - [yes] My code follows the code style of this project. - [no] My change requires a change to the documentation. - [n/a ] I have updated the documentation accordingly. - [yes] I have read the **[CONTRIBUTING](https://github.com/fbsamples/original-coast-clothing/blob/master/CONTRIBUTING.md)** document. - [n/a] I have added tests to cover my changes. - [yes] All new and existing tests passed. - [yes] The title of my pull request is a short description of the requested changes. - [yes] I have added the label **enhancement** to my pull request. Reviewed By: rubycalling Differential Revision: D25869069 Pulled By: Barbog fbshipit-source-id: d06a6640a44b38a5cf7da55ec973ac777bab4493
…ku details. (fbsamples#74) Summary: #### Is your pull request related to a problem? Please describe Was asked to go through Messenger bootcamp tasks and note items that were broken, confusing or out of date. This PR fixes items that I found. - Localtunnel is not longer supported by FB. It's domain (`loca.lt`)is marked as serving malicious content. It will return an error with: ``` message: "Your message couldn't be sent because it includes content that other people on Facebook have reported as abusive.", type: 'OAuthException', ``` - ~~For now I just removed references to it. Not sure if we'd want to list ngrok or similar as alternative.~~ Updated to use ngrok as example. - Updated verbiage that appears on the Messenger dashboard page. (Wording had slightly changed) - Enhanced the Heroku description, including logging and env var setting. - Fix git handling under Heroku—there was a superfluous initialization of git. - Various typo and formatting fixes. #### Checklist - [X] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [X] I have updated the documentation accordingly. - [X] I have read the **[CONTRIBUTING](https://github.com/fbsamples/original-coast-clothing/blob/master/CONTRIBUTING.md)** document. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed. - [X] The title of my pull request is a short description of the requested changes. - [ ] I have added the label **enhancement** to my pull request. Pull Request resolved: fbsamples#74 Reviewed By: Barbog Differential Revision: D26199387 Pulled By: wanderingstan fbshipit-source-id: e7c804c7550586caeb5c697ce19ef04cc5840c5e
Summary: Sample Product website was updated to display "2021", so the bot should be updated too. Reviewed By: Barbog Differential Revision: D28630703 fbshipit-source-id: 5a7de11e8ac1cf60c7265155564f01737b96c635
Summary: Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/f299b52f39486275a9e6483b60a410e06520c538"><code>f299b52</code></a> Bump to v4.17.21</li> <li><a href="https://github.com/lodash/lodash/commit/c4847ebe7d14540bb28a8b932a9ce1b9ecbfee1a"><code>c4847eb</code></a> Improve performance of <code>toNumber</code>, <code>trim</code> and <code>trimEnd</code> on large input strings</li> <li><a href="https://github.com/lodash/lodash/commit/3469357cff396a26c363f8c1b5a91dde28ba4b1c"><code>3469357</code></a> Prevent command injection through <code>_.template</code>'s <code>variable</code> option</li> <li>See full diff in <a href="https://github.com/lodash/lodash/compare/4.17.20...4.17.21">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/fbsamples/original-coast-clothing/network/alerts). </details> Pull Request resolved: fbsamples#79 Reviewed By: Barbog Differential Revision: D29036818 Pulled By: wanderingstan fbshipit-source-id: f9f88caf9f0210c2a99ca7f2eb43534c628b2f5a
Summary: Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/gulpjs/glob-parent/releases">glob-parent's releases</a>.</em></p> <blockquote> <h2>v5.1.2</h2> <h3>Bug Fixes</h3> <ul> <li>eliminate ReDoS (<a href="https://github-redirect.dependabot.com/gulpjs/glob-parent/issues/36">https://github.com/fbsamples/original-coast-clothing/issues/36</a>) (<a href="https://github.com/gulpjs/glob-parent/commit/f9231168b0041fea3f8f954b3cceb56269fc6366">f923116</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md">glob-parent's changelog</a>.</em></p> <blockquote> <h3><a href="https://github.com/gulpjs/glob-parent/compare/v5.1.1...v5.1.2">5.1.2</a> (2021-03-06)</h3> <h3>Bug Fixes</h3> <ul> <li>eliminate ReDoS (<a href="https://github-redirect.dependabot.com/gulpjs/glob-parent/issues/36">https://github.com/fbsamples/original-coast-clothing/issues/36</a>) (<a href="https://github.com/gulpjs/glob-parent/commit/f9231168b0041fea3f8f954b3cceb56269fc6366">f923116</a>)</li> </ul> <h2><a href="https://www.github.com/gulpjs/glob-parent/compare/v5.1.2...v6.0.0">6.0.0</a> (2021-05-03)</h2> <h3>{emoji:26a0} BREAKING CHANGES</h3> <ul> <li>Correct mishandled escaped path separators (<a href="https://github-redirect.dependabot.com/gulpjs/glob-parent/issues/34">https://github.com/fbsamples/original-coast-clothing/issues/34</a>)</li> <li>upgrade scaffold, dropping node <10 support</li> </ul> <h3>Bug Fixes</h3> <ul> <li>Correct mishandled escaped path separators (<a href="https://github-redirect.dependabot.com/gulpjs/glob-parent/issues/34">https://github.com/fbsamples/original-coast-clothing/issues/34</a>) (<a href="https://www.github.com/gulpjs/glob-parent/commit/32f6d52663b7addac38d0dff570d8127edf03f47">32f6d52</a>), closes <a href="https://github-redirect.dependabot.com/gulpjs/glob-parent/issues/32">https://github.com/fbsamples/original-coast-clothing/issues/32</a></li> </ul> <h3>Miscellaneous Chores</h3> <ul> <li>upgrade scaffold, dropping node <10 support (<a href="https://www.github.com/gulpjs/glob-parent/commit/e83d0c5a411947cf69eb58f36349db80439c606f">e83d0c5</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/gulpjs/glob-parent/commit/eb2c439de448c779b450472e591a2bc9e37e9668"><code>eb2c439</code></a> chore: update changelog</li> <li><a href="https://github.com/gulpjs/glob-parent/commit/12bcb6c45c942e2d05fc1e6ff5402e72555b54b6"><code>12bcb6c</code></a> chore: release 5.1.2</li> <li><a href="https://github.com/gulpjs/glob-parent/commit/f9231168b0041fea3f8f954b3cceb56269fc6366"><code>f923116</code></a> fix: eliminate ReDoS (<a href="https://github-redirect.dependabot.com/gulpjs/glob-parent/issues/36">https://github.com/fbsamples/original-coast-clothing/issues/36</a>)</li> <li><a href="https://github.com/gulpjs/glob-parent/commit/0b014a7962789b2d8f2cf0b6311f40667aecd62c"><code>0b014a7</code></a> chore: add JSDoc returns information (<a href="https://github-redirect.dependabot.com/gulpjs/glob-parent/issues/33">https://github.com/fbsamples/original-coast-clothing/issues/33</a>)</li> <li><a href="https://github.com/gulpjs/glob-parent/commit/2b24ebd64b2a045aa167c825376335555da139fd"><code>2b24ebd</code></a> chore: generate initial changelog</li> <li>See full diff in <a href="https://github.com/gulpjs/glob-parent/compare/v5.1.1...v5.1.2">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/fbsamples/original-coast-clothing/network/alerts). </details> Pull Request resolved: fbsamples#80 Reviewed By: wanderingstan Differential Revision: D29062437 Pulled By: Barbog fbshipit-source-id: a82a1af8fb096daa39203c1f2c947b42fcb88c11
Summary: Addressing a tiny contributor request to improve readability fbsamples#55 Reviewed By: wanderingstan Differential Revision: D29196791 fbshipit-source-id: 54e4bb0db7d105ab4ad9720acc669fcb38b9a1a7
Summary: - Update OCC-msgr with many of the fixes in OCC-ig - remove deprecated request libary, switch to node-fetch (see below) - move to async/await pattern - bump version of graphAPI used (with subequent removal of nested menus, and thus the menu. support text string) - improved logging - remove FBA code now that its deprecated - remove assignees from github; let oncall handle it (see D29161788) - output variable names in console.log() calls. See: https://stackoverflow.com/questions/48087850/how-to-console-log-the-name-of-a-variable-function Why fetch? - fetch is part of the web standard, defined here: https://fetch.spec.whatwg.org/ - It's standard in browsers, so its the one API all js devs should know, and most likely to be known by only casual js devs (e.g. python, php, or swift devs) - It supports modern asyn/await Reviewed By: Barbog Differential Revision: D29081579 fbshipit-source-id: 42090938800cb791a1767d0d580f52f621422245
Summary: Somehow a stray semicolon got in the code. Random keypress? Reviewed By: Barbog Differential Revision: D29393910 fbshipit-source-id: d5f2c97834a2b8b445f2c6de15ddd397b5ecd014
Summary: #### Is your pull request related to a problem? Please describe Yes it is. It will be great if this experience would be also in polish. #### Describe the solution you'd like I've just added new locale Pull Request resolved: fbsamples#72 Test Plan: A good test plan should give instructions that someone else can easily follow. Also add a link to your own Messenger experience for your reviewer to test the changes. #### Checklist - [x] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [x] I have read the **[CONTRIBUTING](https://github.com/fbsamples/original-coast-clothing/blob/master/CONTRIBUTING.md)** document. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed. - [x] The title of my pull request is a short description of the requested changes. - [ ] I have added the label **enhancement** to my pull request. Reviewed By: wanderingstan Differential Revision: D26725795 Pulled By: Barbog fbshipit-source-id: ea61d33a3112aeee5b577774c83e450f4b050cb1
Summary: Bot was failing when receiving the Echo webhook. This corrects it. Reviewed By: Riandy Differential Revision: D30933961 fbshipit-source-id: 34c2b68409ee2a7cc57a1feed8d9f67f11e90287
Summary: Branch has been renamed. This updates textual references as per https://fb.workplace.com/groups/opensourceatfb/permalink/4287536441290069/. Reviewed By: wanderingstan Differential Revision: D31052769 fbshipit-source-id: 9e8bcfc985a1119dfa0123508e9494b7d445a310
Summary: To highlight one of the entrypoints in the OCC bot, I've added more explicit text saying "Thank you for wanting to make an appointment." Reviewed By: wanderingstan Differential Revision: D31403519 fbshipit-source-id: ce8201ab67bfabe1995a2923ecb4085e5b068dbc
Summary: * Updated a package * Updated working in licencing and readme to use Meta instead of Facebook Reviewed By: wanderingstan Differential Revision: D33632544 fbshipit-source-id: b6a35816c92e62e720398528eeaa86449e49e1c7
Summary: #### Is your pull request related to a problem? Please describe A clear and concise description of what the problem is. Ex. I'm always frustrated when ... #### Describe the solution you'd like A clear and concise description of what you want to happen. #### Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered. #### Additional context Add any other context or screenshots about the feature request here. Pull Request resolved: fbsamples#102 Test Plan: A good test plan should give instructions that someone else can easily follow. Also add a link to your own Messenger experience for your reviewer to test the changes. #### Checklist - [ ] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have read the **[CONTRIBUTING](https://github.com/fbsamples/original-coast-clothing/blob/main/CONTRIBUTING.md)** document. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed. - [ ] The title of my pull request is a short description of the requested changes. - [ ] I have added the label **enhancement** to my pull request. Differential Revision: D35859526 Pulled By: nijohn fbshipit-source-id: 1cddabf1bc5f3b1b60bd1b56b1b682cd7ee50578
Summary: Changes to accomodate: 1. User Profiel API failures 2. Adding default values for locale and names 3. Handling Chat plugin user_ref and guest_mode Pull Request resolved: fbsamples#103 Reviewed By: wanderingstan Differential Revision: D36024422 Pulled By: gitLee47 fbshipit-source-id: ba76b303b592cf95af1d0765036934f17493d984
Summary: Updated photos and images to match website. Pull Request resolved: fbsamples#104 Reviewed By: nijohn Differential Revision: D36220722 Pulled By: wanderingstan fbshipit-source-id: bc9e59db5ae213339c333f40a2fb0cbc64f0c505
Summary: #### Is your pull request related to a problem? Please describe While the [sample tutorial](https://developers.facebook.com/docs/messenger-platform/getting-started/sample-experience), a error was shown for the NLP saying `Unable to activate built-in NLP: Bad Request` while doing the app setup configuration on link `http://<APP_HOST_URL>/profile?mode=all&verify_token=<VERIFY_TOKEN>`  #### Describe the solution The error is a malformed URL on: https://github.com/fbsamples/original-coast-clothing/blob/main/services/graph-api.js#L214 Just change the line for: `` let url = new URL(`${config.apiUrl}`/me/nlp_configs); `` Pull Request resolved: fbsamples#106 Test Plan: https://user-images.githubusercontent.com/26100917/167716327-4b4d9310-4234-4b51-b5e2-72277d90ee02.mov #### Checklist - [x] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [x] I have read the **[CONTRIBUTING](https://github.com/fbsamples/original-coast-clothing/blob/main/CONTRIBUTING.md)** document. - [ ] I have added tests to cover my changes. - [x] All new and existing tests passed. - [x] The title of my pull request is a short description of the requested changes. - [x] I have added the label **enhancement** to my pull request. Reviewed By: wanderingstan Differential Revision: D36294102 Pulled By: akotadi fbshipit-source-id: 434159f28f8bcdf303889280be076d73d1255487
Summary: #### Is your pull request related to a problem? Please describe Added the new feature changes w.r.t Recurring Notifications #### Describe the solution you'd like When the user clicks on https://m.me/originalcoastclothing?ref=product_launch the page will send an opt in template for users to opt in. Once the user opts in a follow up message is sent. #### Additional context Based on this https://developers.facebook.com/docs/messenger-platform/send-messages/recurring-notifications Pull Request resolved: fbsamples#108 Test Plan: A good test plan should give instructions that someone else can easily follow. Also add a link to your own Messenger experience for your reviewer to test the changes. #### Checklist - [ ] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have read the **[CONTRIBUTING](https://github.com/fbsamples/original-coast-clothing/blob/main/CONTRIBUTING.md)** document. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed. - [ ] The title of my pull request is a short description of the requested changes. - [ ] I have added the label **enhancement** to my pull request. Can test by visiting https://m.me/originalcoastclothing?ref=product_launch Reviewed By: jorgeluiso Differential Revision: D36505326 Pulled By: nijohn fbshipit-source-id: 831ff0d7e36d1fc61cec5f90121f8a111f7a1e15
Summary: Added support for Lead Generation Ads https://developers.facebook.com/docs/messenger-platform/discovery/lead-generation-ads-in-messenger This adds support for following on on the following demo ad: https://www.facebook.com/ads/experience/confirmation/?experience_id=2170497373124589 This is running on the original coast clothing already, to test inject the ad into your feed and expect the Page to be responsive to the ad experience: Pull Request resolved: fbsamples#109 Reviewed By: gitLee47 Differential Revision: D39787796 Pulled By: jorgeluiso fbshipit-source-id: e6ca568323da41ead4fff2760b53f3fe28a7ef1d
Summary: Add new flow to support reporting complete leads. This new flow can be tested via this demo Click To Messenger Ad that supports complete lead reporting for ad ranking: https://www.facebook.com/ads/experience/confirmation/?experience_id=603186808257936 Note that this is different from the Lead Generation in Messenger Product. That one transfers control to the app once the lead is complete while this new one is a CTM ad that supports leads as a reported signal. https://developers.facebook.com/docs/messenger-platform/discovery/lead-generation-ads-in-messenger # Other Changes * This PR also updates package dependency versions mainly to keep the code current and address security vulnerabilities of the dependencies. * Lint version and lint spec updates to help dev setup as well as code formatting * `yarn lint --fix` * Translations for new prompts in the CTM to Lead flow * Addresses EJS lint issue * Merge with the production deployed bot supporting https://m.me/542998526103632 to make sure this code matches what you can experience Pull Request resolved: fbsamples#110 Reviewed By: gitLee47 Differential Revision: D40047919 Pulled By: jorgeluiso fbshipit-source-id: bf01b979eb2e0bb72ecb977270210a71e3b5ebca
facebook-github-bot
added
the
CLA Signed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your pull request related to a problem? Please describe
A clear and concise description of what the problem is. Ex. I'm always frustrated when ...
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Test plan
A good test plan should give instructions that someone else can easily follow.
Also add a link to your own Messenger experience for your reviewer to test the changes.
Checklist