Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

light/dark mode switch added #545

Closed
wants to merge 5 commits into from
Closed

light/dark mode switch added #545

wants to merge 5 commits into from

Conversation

Alirezaaraby
Copy link

@Alirezaaraby Alirezaaraby commented Feb 1, 2023 •
edited
Loading

toggle dark/light mode added to docs

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

📝 Docs preview for commit b6b23e5 at: https://63da54924348a90aea146064--typertiangolo.netlify.app

atmartinez
atmartinez reviewed Feb 16, 2023
View reviewed changes
mkdocs.yml Outdated Show resolved Hide resolved
@github-actions
Copy link

📝 Docs preview for commit d391d62 at: https://63ee58cbe3b9652cf79fa262--typertiangolo.netlify.app

@github-actions
Copy link

📝 Docs preview for commit 1706ceb at: https://63ee5a4409d84b2f89a11ba9--typertiangolo.netlify.app

@github-actions
Copy link

📝 Docs preview for commit 5bd3644 at: https://63ee5ce009d84b3117a11e2d--typertiangolo.netlify.app

atmartinez
atmartinez approved these changes Feb 17, 2023
View reviewed changes
Copy link

@atmartinez atmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me for this specific doc style change. I would consider swapping the accent colors to amber to match FastApi docs, but the scope of this PR per the title is to just add the toggle switch.

@Alirezaaraby
Copy link
Author

This looks good to me for this specific doc style change. I would consider swapping the accent colors to amber to match FastApi docs, but the scope of this PR per the title is to just add the toggle switch.

Firstly, typer doc has it's own style so i think there's no need to change the color to amber. And secondly, I wrote light/dark mode switch, and the mode is a key word here which shows this pr will add dark mode switch to typer docs :)

@svlandeg svlandeg added docs Improvements or additions to documentation feature New feature, enhancement or request p3 labels Mar 1, 2024
@svlandeg
Copy link
Member

svlandeg commented Mar 6, 2024 •
edited
Loading

[maintenance note] Related PR: #418

svlandeg
svlandeg reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Alirezaaraby, thanks so much for the contribution!

It looks like in the meantime, dark mode for the docs has been introduced by Tiangolo in PR #908 🎉 As such, I think we can close this one, but thanks again! 🙏

@svlandeg svlandeg closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg left review comments

@atmartinez atmartinez atmartinez approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to documentation feature New feature, enhancement or request p3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alirezaaraby @svlandeg @atmartinez