Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add takerQty and makerQty Properties to Orders, Replacing isMaker Flag #422

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

fasenderos
Copy link
Owner

@fasenderos fasenderos commented Aug 2, 2024

This pull request introduces two new properties, takerQty and makerQty, to the limit order object. These properties provide a more detailed breakdown of the executed quantities of an order, allowing us to distinguish between the parts of the order that acted as a "taker" and those that acted as a "maker".

Previously, the order object included a boolean flag isMaker, which was set to true only if the order was completely a maker order. This approach did not account for partially executed orders, where part of the order could be a maker and part a taker.

The sum of takerQty and makerQty will always equal the original size of the order. This can be used to determine if the order was completely a taker, completely a maker, or a combination of both.

Breaking Changes

  • The isMaker property has been removed from the limit order object.
  • New properties takerQty and makerQty have been added to the limit order objecct.

@fasenderos fasenderos merged commit 7591909 into main Aug 2, 2024
11 checks passed
@fasenderos fasenderos deleted the maker-taker branch August 2, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant