Add takerQty and makerQty Properties to Orders, Replacing isMaker Flag #422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces two new properties,
takerQty
andmakerQty
, to thelimit order
object. These properties provide a more detailed breakdown of the executed quantities of an order, allowing us to distinguish between the parts of the order that acted as a "taker" and those that acted as a "maker".Previously, the order object included a boolean flag
isMaker
, which was set to true only if the order was completely a maker order. This approach did not account for partially executed orders, where part of the order could be a maker and part a taker.The sum of
takerQty
andmakerQty
will always equal the originalsize
of the order. This can be used to determine if the order was completely ataker
, completely amaker
, or a combination of both.Breaking Changes
isMaker
property has been removed from the limit order object.takerQty
andmakerQty
have been added to the limit order objecct.