Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken images and favicon #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pavelhoral
Copy link

This is purely cosmetic PR that fixes Whitelister's logo, OWI logo and replaces default favicon.

Before:

image
image
image

After:

image
image
image

Copy link
Owner

@fantinodavide fantinodavide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavelhoral apologies for taking so long to review this!

everything is looking good, but I have a quick request for you:

  • bump the patch version in the package.json (https://semver.org/)
  • run npm run release
  • commit the new changes

@fantinodavide
Copy link
Owner

also, I always wanted to make this process automated with GitHub Actions, so I'll definitely spend some time on doing so as soon as possible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants