Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules: add runc to known_memfd_execution_binaries #268

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ytsssun
Copy link

@ytsssun ytsssun commented Jan 22, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

Proposed rule maturity level

Uncomment one (or more) /area <> lines (only for PRs that add or modify rules):

/area maturity-stable

/area maturity-incubating

/area maturity-sandbox

/area maturity-deprecated

What this PR does / why we need it:
This PR is to extend the known_memfd_execution_binaries with runc since in 1.1.15 of runc, it introduced a behavior which would use the memfd approach to execute runc binary. This PR is to include the rule for it so that we don't falsely flag the runc binary.

Which issue(s) this PR fixes:

Fixes #3444

Special notes for your reviewer:
I can use come help confirming the change. I was able to verify the override works, see the proof.

But I would need help on verifying that via the first party rules for falco.

@poiana poiana added kind/bug Something isn't working dco-signoff: no area/rules area/maturity-sandbox See the Rules Maturity Framework labels Jan 22, 2025
@poiana poiana requested a review from Kaizhe January 22, 2025 22:10
@poiana
Copy link

poiana commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ytsssun
Once this PR has been reviewed and has the lgtm label, please assign loresuso for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested a review from loresuso January 22, 2025 22:10
@poiana
Copy link

poiana commented Jan 22, 2025

Welcome @ytsssun! It looks like this is your first PR to falcosecurity/rules 🎉

@ytsssun ytsssun force-pushed the update-rule-for-runc-memfd-exec branch from f559f18 to ebccfef Compare January 23, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maturity-sandbox See the Rules Maturity Framework area/rules dco-signoff: yes kind/bug Something isn't working size/XS
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants