Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup dependabot and bump cosign installer to v3.2.0 and always use the latest cosign #186

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Nov 7, 2023

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area rules

Proposed rule maturity level

What this PR does / why we need it:

  • Setup dependabot
  • bump cosign installer to v3.2.0 and use always use the latest cosign

/assign @leogr @LucaGuerra

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: cpanato <[email protected]>
@cpanato cpanato changed the title Setup dependabot and bump cosign installer to v3.1.2 and always use the latest cosign Setup dependabot and bump cosign installer to v3.2.0 and always use the latest cosign Nov 7, 2023
@cpanato
Copy link
Member Author

cpanato commented Nov 7, 2023

/assign @jasondellaluce

@@ -58,9 +58,7 @@ jobs:

# Create a signature of the rules artifact as OCI artifact
- name: Install Cosign
uses: sigstore/[email protected]
with:
cosign-release: 'v2.1.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have to add the release anymore?

Copy link
Contributor

@LucaGuerra LucaGuerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Carlos! Now we need to be consistent across repos ;)

@poiana poiana added the lgtm label Nov 10, 2023
@poiana
Copy link

poiana commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Nov 10, 2023

LGTM label has been added.

Git tree hash: 744e801b12ea56c5b965f0a36f2ae880b8cb4847

@poiana poiana merged commit 35a379a into falcosecurity:main Nov 10, 2023
5 checks passed
@cpanato cpanato deleted the udpates branch November 10, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants