fix(libsinsp): address more review comments

Signed-off-by: Roberto Scolaro <[email protected]>
falcosecurity · Jan 16, 2024 · 48277b1 · 48277b1
1 parent cb309fa
commit 48277b1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/userspace/libsinsp/test/CMakeLists.txt b/userspace/libsinsp/test/CMakeLists.txt
@@ -120,7 +120,6 @@ set(LIBSINSP_UNIT_TESTS_SOURCES
 	thread_table.ut.cpp
 	public_sinsp_API/event_related.cpp
 	public_sinsp_API/sinsp_logger.cpp
-	cri_settings.ut.cpp
 	"${TEST_PLUGINS}"
 	"${SINSP_PARSERS_SUITE}"
 	"${SINSP_CLASSES_SUITE}"

diff --git a/userspace/libsinsp/test/cri_settings.ut.cpp → ...test/container_engine/cri_settings.ut.cpp b/userspace/libsinsp/test/cri_settings.ut.cpp → ...test/container_engine/cri_settings.ut.cpp
@@ -16,10 +16,11 @@ limitations under the License.
 
 */
 
+#if !defined(MINIMAL_BUILD) and !defined(__EMSCRIPTEN__) // MINIMAL_BUILD and emscripten don't support containers at all
 #include <gtest/gtest.h>
 #include <cri.h>
 #include <cri.hpp>
-#include "./sinsp_with_test_input.h"
+#include "../sinsp_with_test_input.h"
 
 
 TEST_F(sinsp_with_test_input, default_cri_socket_paths)
@@ -41,3 +42,4 @@ TEST_F(sinsp_with_test_input, default_cri_socket_paths)
 	ASSERT_TRUE("/run/crio/crio.sock"==socket_paths[1]);
 	ASSERT_TRUE("/run/k3s/containerd/containerd.sock"==socket_paths[2]);
 }
+#endif