Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hieradet.py #167

Merged
merged 5 commits into from
Aug 9, 2024
Merged

Update hieradet.py #167

merged 5 commits into from
Aug 9, 2024

Conversation

arun477
Copy link
Contributor

@arun477 arun477 commented Aug 7, 2024

Not required in init (if we want to be clear we can pass the scale to F.scaled_dot_product_attention) .

head_dim = dim_out // num_heads
self.scale = head_dim**-0.5

F.scaled_dot_product_attention takes care of this automatically.

Not used  
head_dim = dim_out // num_heads
self.scale = head_dim**-0.5

F.scaled_dot_product_attention takes care of this automatically.
Copy link
Contributor

@chayryali chayryali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can we update the formatting using ufmt?

@arun477
Copy link
Contributor Author

arun477 commented Aug 9, 2024

Hi @chayryali, I've updated the formatting.

Thanks!

@arun477 arun477 requested a review from chayryali August 9, 2024 10:35
@chayryali chayryali merged commit 778e112 into facebookresearch:main Aug 9, 2024
2 checks passed
yanyilyu pushed a commit to yanyilyu/segment-anything-2 that referenced this pull request Sep 17, 2024
remove unused attributes from hieradet.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants