Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stubs to python bindings to provide typing information. #2415

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Jun 25, 2024

Motivation and Context

This changeset adds stubs to python bindings to provide typing information.
Stub generation depends on pybind11-stubgen.

typing-2024-06-16_22.01.01.mp4

How to test:

  • pip install pybind11-stubgen.
  • Build habitat-sim normally.
  • Import the package in another project, and explore types in your IDE.

WIP:

  • Stubs contain some errors, but they mostly work.
  • CI is not yet handled.
  • Ideally, creating a stub package would scale better, but I could not make it work with bindings. See PEP 561.

How Has This Been Tested

Tested by importing habitat_sim in an external Python file.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@0mdc 0mdc requested review from mosra, jturner65 and aclegg3 June 25, 2024 19:07
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 25, 2024
@0mdc 0mdc force-pushed the 0mdc/bindings_typing branch from 181e7cd to 060dde3 Compare July 16, 2024 19:20
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see slack thread here

@0mdc 0mdc force-pushed the 0mdc/bindings_typing branch from 5504972 to c70299f Compare January 19, 2025 17:11
@0mdc 0mdc marked this pull request as ready for review January 21, 2025 17:43
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Excited to have this, thanks!

@0mdc 0mdc requested a review from jturner65 January 21, 2025 18:29
@jturner65
Copy link
Contributor

Eventually it would be good to separate the binding process so that all the enums and classes are instantiated in appropriate order and then all their method bindings are added. This will address circular refs between class methods, where each class has a method argument referencing the other class.

@mosra
Copy link
Collaborator

mosra commented Jan 22, 2025

That I'm (partially) handling in the m.css stub output already (#2477) -- there it's the types first and functions after. Doesn't handle type dependencies yet but internally it has knowledge about their dependencies so it could attempt to either sort them or make "forward declarations" when dependencies are cyclic (i.e., stringified annotations).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants