isolate use of folly to interpolateViewProps on Android #48556
Closed
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67942951 |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Jan 9, 2025
Summary: changelog: [react-native] the only place in view module that uses folly is `ViewPropsInterpolation.h` and that is only on Android. This diff makes that dependency explicit and make it android only. Differential Revision: D67942951
sammy-SC
force-pushed
the
export-D67942951
branch
from
87402bd to
dbb16f3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67942951 |
Summary: changelog: [react-native] the only place in view module that uses folly is `ViewPropsInterpolation.h` and that is only on Android. This diff makes that dependency explicit and make it android only. Differential Revision: D67942951
sammy-SC
force-pushed
the
export-D67942951
branch
from
dbb16f3 to
e6cf603
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67942951 |
|
This pull request has been merged in 8369922. |
|
This pull request was successfully merged by @sammy-SC in 8369922 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [react-native]
the only place in view module that uses folly is
ViewPropsInterpolation.hand that is only on Android.This diff makes that dependency explicit and make it android only.
Differential Revision: D67942951