-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Login Callback #142
base: main
Are you sure you want to change the base?
Fix Login Callback #142
Conversation
…layer backgrounds the app with the login screen visible, and resumes the app from the app launcher (not the recent apps).
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Any idea when this could be merged? |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
1 similar comment
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Is there anything stopping this from being merged? |
Is there a plan to merge this fix in? |
I think it's ready for merge, just waiting on Facebook. @KylinChang |
This will fix the login callback not being called on Android if the player backgrounds the app with the login screen visible, and resumes the app from the app launcher (not the recent apps).
Issue: #66