Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refacto(src/main/java/io/fabric8/maven/docker/util/ImageName.java)r:Removed unorganized getters and orgnaized by Lombok getters #1727

Closed
wants to merge 1 commit into from

Conversation

mdxabu
Copy link
Contributor

@mdxabu mdxabu commented Nov 22, 2023

I removed some unorganized getters and made them organized and efficient using Lombok @Getter.

Signed-off-by: Mohamed Abdullah [email protected]

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #1727 (7147158) into master (1b4dec5) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1727   +/-   ##
=========================================
  Coverage     65.25%   65.25%           
  Complexity     2276     2276           
=========================================
  Files           172      172           
  Lines         10165    10165           
  Branches       1401     1401           
=========================================
  Hits           6633     6633           
  Misses         2983     2983           
  Partials        549      549           
Files Coverage Δ
...in/java/io/fabric8/maven/docker/util/GavLabel.java 76.47% <ø> (ø)
...n/java/io/fabric8/maven/docker/util/ImageName.java 95.00% <100.00%> (ø)

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@rhuss
Copy link
Collaborator

rhuss commented Nov 28, 2023

Thanks for the PR, but please no Lombok, only for replacing getters. I'm not a big fan of adding an extra dependency only for a little syntactic sugar. The decision of introducing Lombok or not has a wider scope than just sneaking it in via a PR. If you feel inclined, feel free to open an issue to discuss, but please be aware that we could live without Lombok quite nicely over all those years, so would you need to have really good arguments.

I'm closing this PR, but please feel free to elaborate on what you mean by "unorganized" and what value that would bring to the project. But thanks again, really appreciate that you care about code quality.

@rhuss rhuss closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants