Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reformat d_deh.c #2146

Merged
merged 8 commits into from
Jan 17, 2025
Merged

reformat d_deh.c #2146

merged 8 commits into from
Jan 17, 2025

Conversation

rfomin
Copy link
Collaborator

@rfomin rfomin commented Jan 16, 2025

No description provided.

@fabiangreffrath
Copy link
Owner

Thank you, much better now!

The only thing that bothers me is how some original Boom comments have been mangled and now the formatting aparently makes less sense. For example:

  // replace it but don't overflow it.  Use current length as limit.
  // Ty 03/13/98 - add 0xff code
  // Deal with the fact that the cheats in deh files are extended
  // with character 0xFF to the original cheat length, which we don't do.

in line 2769ff has become

  // replace it but don't overflow it.  Use current length as
  // limit. Ty 03/13/98 - add 0xff code Deal with the fact
  // that the cheats in deh files are extended with character
  // 0xFF to the original cheat length, which we don't do.

@rfomin
Copy link
Collaborator Author

rfomin commented Jan 16, 2025

The only thing that bothers me is how some original Boom comments have been mangled and now the formatting aparently makes less sense.

Fixed some in 263498d

@fabiangreffrath
Copy link
Owner

Fixed some in 263498d

There is another such case around line 2687(old)->2677(new).

@rfomin
Copy link
Collaborator Author

rfomin commented Jan 17, 2025

Fixed some in 263498d

There is another such case around line 2687(old)->2677(new).

Fixed in a897465

Copy link
Owner

@fabiangreffrath fabiangreffrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rfomin rfomin merged commit 075b47e into fabiangreffrath:master Jan 17, 2025
8 checks passed
@rfomin rfomin deleted the refactor_deh branch January 17, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants