expand exit sequence support to include PWAD endoom + no sound #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfomin
approved these changes
Dec 18, 2024
rfomin
reviewed
Dec 18, 2024
|
Hm, don't you think that "Show ENDOOM: yes, no, PWAD only" and "Play End Sound: yes, no" would be less confusing? |
However, this would drop the "ENDOOM + sound for PWAD only" option. It's okay, thank you! |
fabiangreffrath
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per request:
Perhaps this could be merged with the normal Exit Sequence setting, leading to five total options in one setting, however this way feels simpler to understand, in my opinion. All feedback is appreciated.