move player pain sound to the sg_oof sound group
#2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents the chainsaw idle sound and the player pain sound from interruting each other. https://www.doomworld.com/forum/topic/112333-this-is-woof-1501-dec-06-2024/?page=103&tab=comments#comment-2877815 This fix seems plausible since both "Oof!" and "Ouch!" are voiceful expressions. ;)
|
This is normal behavior, right? What are the side effects to changing this? Are other sounds now being cut off? |
Now "Ouch!" and "Oof!" could interrupt each other. |
rfomin
approved these changes
Dec 15, 2024
|
The alternative solution would have been to move the saw sounds into their own group, but I think this change is less disruptive and follows the existing logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the chainsaw idle sound and the player pain sound from interruting each other.
https://www.doomworld.com/forum/topic/112333-this-is-woof-1501-dec-06-2024/?page=103&tab=comments#comment-2877815
This fix seems plausible since both "Oof!" and "Ouch!" are voiceful expressions. ;)