Trust samba ad

[abbra]

test

[netoarmando]

This PR is being tested by PR-CI using the changes suggested here: freeipa/freeipa-pr-ci#259.

[netoarmando]

@abbra As of today, test_trust.py requires an AD subdomain and AD tree domain, as we can see here:

freeipa/ipatests/test_integration/test_trust.py

Lines 30 to 35 in 3337840

	class ADTrustBase(IntegrationTest):
	"""Provides common checks for the AD trust integration testing."""
	topology = 'line'
	num_ad_domains = 1
	optional_extra_roles = ['ad_subdomain', 'ad_treedomain']

That num_ad_domains is used here:

freeipa/ipatests/pytest_ipa/integration/__init__.py

Lines 218 to 226 in 3337840

	for _i in range(cls.num_ad_domains):
	domain_descriptions.append({
	'type': 'AD',
	'hosts': {
	'ad': 1,
	'ad_subdomain': cls.num_ad_domains,
	'ad_treedomain': cls.num_ad_domains,
	}
	})

However, on PR-CI we only have the AD (root) and the child hosts, to be able to execute the tests right now I'm pointing the ad_treedomain to the child instance. Any thoughts?

[abbra]

Tree root domain is a domain that is part of the forest but is not subordinate in terms of DNS. Eg. if you have AD forest root ad.vm, a child domain child.ad.vm, then a domain named some.test would be a tree root domain for forest ad.vm if it is part of ad.vm forest.

[abbra]

@f-trivino, @netoarmando we need to have samba-client installed on the master -- without it all tests in test_trust.py are skipped.

('/usr/lib/python3.7/site-packages/_pytest/nose.py', 22, 'Skipped: Package samba-client not available on master.ipa.test')