Feature/3 fetch images #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-tony
requested changes
Jan 13, 2025
app/src/main/java/com/example/objectdetection/activity/MainActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/objectdetection/repository/UnsplashRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/objectdetection/repository/UnsplashRepository.kt
Show resolved
Hide resolved
1. 검색창에 적은 텍스트를 오른쪽 보내기 버튼을 누르면 해당 단어의 리스트를 받아오도록 수정 2. mvvm 패턴과 코루틴으로 view 분리 + main -> feature3 rebase TODO 1. notifyDataSetChange() 변경 필요
yujung5873
force-pushed
the
feature/3-fetch-images
branch
from
c34d188 to
132ed55
Compare
initSearchView() 에서 불필요한 CoroutineScope 사용 제거
예외 상황에서는 null을 반환하고, errorToast를 띄우도록 수정 -> 성공했지만 검색 결과가 empty인 경우와 구분
|
f-lab-tony
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
#3
📝작업 내용
###TODO