Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process/signin process #26

Merged
merged 10 commits into from
Feb 3, 2025
Merged

Process/signin process #26

merged 10 commits into from
Feb 3, 2025

Conversation

cjhih456
Copy link
Collaborator

작업 내용

  • 회원가입 절차 수정

추가된 사항

수정한 사항

  • 로그인 중 메인 페이지 EmailSubmitForm 수정
  • 로그인 중 회원가입 페이지 링크 수정

시도하본 요소

@cjhih456 cjhih456 added the enhancement New feature or request label Jan 27, 2025
@cjhih456 cjhih456 requested a review from virere January 27, 2025 08:56
@cjhih456 cjhih456 self-assigned this Jan 27, 2025
@cjhih456 cjhih456 linked an issue Jan 27, 2025 that may be closed by this pull request
Comment on lines 29 to 30
queryClient.clear()
await refetch()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분은 queryClient를 clear 하는 것 보다는, 명시적으로 특정 query의 query key를 가져와서 invalidateQueries를 해주는게 좋습니다.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아하 queryClient.clear()로 하면 모든 쿼리를 다시 실행하게 된다는 부분에 있어 안좋은 부분이 있겠네요.
실수했네요.. ㅠ

해당 부분 invalidateQueries로 변경하여 보았습니답
2da53b6

@cjhih456 cjhih456 force-pushed the process/signin-process branch from 177ca7d to cd75d80 Compare January 27, 2025 13:12
@cjhih456 cjhih456 merged commit 959f204 into main Feb 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

로그인직후 메인화면 의 변화
2 participants