스플래시 화면 구현 #11
Closed
스플래시 화면 구현 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
abdul0986
suggested changes
Jan 14, 2025
| } | ||
| } | ||
| let hexFormatted = hex.trimmingCharacters(in: .whitespacesAndNewlines).replacingOccurrences(of: "#", with: "") | ||
| guard hexFormatted.count == 6, |
There was a problem hiding this comment.
Integer의 경우, 리터럴을 코드 내에서 바로 사용하게 되면 가독성 및 인지 오류의 문제가 야기됩니다. 가급적 정적상수로 선언하거나 enum 하위 항목으로 정의해서 상수 형태로 사용하는 습관을 들여주시길 권장합니다
Comment on lines
+18
to
+19
| DispatchQueue.main.asyncAfter(deadline: .now() + 2) { | ||
| self.router?.pushToContentsView() |
There was a problem hiding this comment.
'2'라는 리터럴이 의미하는 바가 코드 내에서 모호하기 때문에, 보다 분명하게 정의할 수 있도록 splashFreezeMargin과 같은 상수를 정의하여 사용하는 편이 좋습니다.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
스플래시 화면(인트로) 구현 완료 하였습니다.