Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitignore 추가 #10

Merged
merged 3 commits into from
Jan 15, 2025
Merged

gitignore 추가 #10

merged 3 commits into from
Jan 15, 2025

Conversation

NORIKIM
Copy link
Collaborator

@NORIKIM NORIKIM commented Jan 7, 2025

gitignore 값 추가 하였습니다.

추가 내용

  • Pods 폴더
  • xcuserdata

@NORIKIM NORIKIM added the documentation Improvements or additions to documentation label Jan 7, 2025
@NORIKIM NORIKIM added this to the 오늘뭐봄 milestone Jan 7, 2025
@NORIKIM NORIKIM requested a review from abdul0986 January 7, 2025 06:20
@NORIKIM NORIKIM self-assigned this Jan 7, 2025
Copy link

@abdul0986 abdul0986 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • SPM(SwiftPackageManager)나 빌드 속성 같은 항목들에 대한 보완이 좀 필요해 보여요

  • xcodeproj/project.xcworkspace 같은 프로젝트 상태 관리 파일들이 다 주석 처리 되어 있어서, 나중이 되면 아마 깃이 좀 지저분해질 수 있을 것 같은데요, 이유가 있을까요?

보통 toptal.com 같은 데서 xcode, swiftpackagemanager 같은 키워드 넣고 생성 요청하면 그 키워드에 맞는 gitignore 만들어주거든요. 사용해 보신 적 있으세요?

@NORIKIM
Copy link
Collaborator Author

NORIKIM commented Jan 10, 2025

toptal 이용하여 ignore 수정해보았습니다

키워드: xcode, swiftpackagemanager, swift

Copy link

@abdul0986 abdul0986 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피드백 확인 부탁드려요

.gitignore Outdated
/*.gcno
**/xcshareddata/WorkspaceSettings.xcsettings

# End of https://www.toptal.com/developers/gitignore/api/xcode,swiftpackagemanager,swift

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOL (End Of Line) 공백 추가 부탁드립니다.

@NORIKIM
Copy link
Collaborator Author

NORIKIM commented Jan 14, 2025

EOL 추가 했습니다!

Copy link

@abdul0986 abdul0986 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NORIKIM NORIKIM merged commit 4069ae4 into main Jan 15, 2025
2 checks passed
@NORIKIM NORIKIM deleted the Docs/gitignore branch January 22, 2025 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants