ignore conditional comments

ezyang · Mar 12, 2024 · b7bf895 · b7bf895
1 parent 9ca5a36
commit b7bf895
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 34 deletions.
diff --git a/library/HTMLPurifier/Lexer.php b/library/HTMLPurifier/Lexer.php
@@ -269,20 +269,6 @@ protected static function escapeCommentedCDATA($string)
         );
     }
 
-    /**
-     * Special Internet Explorer conditional comments should be removed.
-     * @param string $string HTML string to process.
-     * @return string HTML with conditional comments removed.
-     */
-    protected static function removeIEConditional($string)
-    {
-        return preg_replace(
-            '#<!--\[if [^>]+\]>.*?<!\[endif\]-->#si', // probably should generalize for all strings
-            '',
-            $string
-        );
-    }
-
     /**
      * Callback function for escapeCDATA() that does the work.
      *
@@ -323,8 +309,6 @@ public function normalize($html, $config, $context)
         // escape CDATA
         $html = $this->escapeCDATA($html);
 
-        $html = $this->removeIEConditional($html);
-
         // extract body from document if applicable
         if ($config->get('Core.ConvertDocumentToFragment')) {
             $e = false;

diff --git a/tests/HTMLPurifier/LexerTest.php b/tests/HTMLPurifier/LexerTest.php
@@ -380,6 +380,20 @@ public function test_tokenizeHTML_malformedComment()
         );
     }
 
+    public function test_tokenizeHTML_conditionalComments()
+    {
+        $this->assertTokenization(
+            '<!--[if mso]>A<![endif]-->B<!--[if !mso]><!---->C<!-- <![endif]-->',
+            array(
+                new HTMLPurifier_Token_Comment('[if mso]>A<![endif]'),
+                new HTMLPurifier_Token_Text("B"),
+                new HTMLPurifier_Token_Comment('[if !mso]><!--'),
+                new HTMLPurifier_Token_Text("C"),
+                new HTMLPurifier_Token_Comment(' <![endif]'),
+            )
+        );
+    }
+
     public function test_tokenizeHTML_unterminatedTag()
     {
         $this->assertTokenization(
@@ -785,14 +799,6 @@ public function test_tokenizeHTML_()
         );
     }
 
-    public function test_tokenizeHTML_ignoreIECondComment()
-    {
-        $this->assertTokenization(
-            '<!--[if IE]>foo<a>bar<!-- baz --><![endif]-->',
-            array()
-        );
-    }
-
     public function test_tokenizeHTML_removeProcessingInstruction()
     {
         $this->config->set('Core.RemoveProcessingInstructions', true);
@@ -824,16 +830,6 @@ public function test_tokenizeHTML_noRemoveNewline()
         );
      }
 
-    public function test_tokenizeHTML_conditionalCommentUngreedy()
-    {
-        $this->assertTokenization(
-            '<!--[if gte mso 9]>a<![endif]-->b<!--[if gte mso 9]>c<![endif]-->',
-            array(
-                new HTMLPurifier_Token_Text("b")
-            )
-        );
-    }
-
     public function test_tokenizeHTML_imgTag()
     {
         $start = array(