-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: support env EZA_QUOTING_STYLE, replace --no-quotes with --quotes=always,auto,never #587
base: main
Are you sure you want to change the base?
Conversation
EDIT: should be all set now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great. Maybe we could use some tests ?
I mean, right now I do kinda feel comfortable with just saying goodbye to the |
SO, I tried to fix the conflicts here (sorry for necrobumping but I thought it would be fun to try and clear out a bit of backlog). Did we ever talk about perhaps keeping around a backward compat |
I honestly don't remember if we did. Seems like a reasonable thing to do tho, just to avoid breaking anything |
0acaa6f
to
ed79105
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the --quotes
options to the bash completion and missing automatic
option to flags.rs
WHEN
array, as well as a few minor fixes here and there. Otherwise LGTM, would also prefer that to the current --no-quotes
! Great!
…support EZA_QUOTING_STYLE Let's imagine this went well... Signed-off-by: Preston Thorpe <[email protected]> Co-authored-by: Preston Thorpe <[email protected]> Co-authored-by: Christina Sørensen <[email protected]> Co-authored-by: Sandro-Alessio Gierens <[email protected]>
Signed-off-by: Preston Thorpe <[email protected]> Co-authored-by: Preston Thorpe <[email protected]> Co-authored-by: Christina Sørensen <[email protected]>
Signed-off-by: Preston Thorpe <[email protected]> Co-authored-by: Preston Thorpe <[email protected]> Co-authored-by: Christina Sørensen <[email protected]>
Signed-off-by: Sandro-Alessio Gierens <[email protected]>
#584
Got me thinking about the different quoting styles that LS supports, and I think it's reasonable to offer some of this. Also, I am not a fan of the
--no-x
flags. I think it makes much more sense to offer an ENV var solution forNEVER
and default it toauto
and then offer a way to pass it in the command line. Idk who would want all their filenames quoted but hey, it's an option for LS.It would obviously remain defaulted to
auto
, so the only thing that would break would be the--no-quotes
flag would have to either be--quotes=never
or theEZA_QUOTING_STYLE=never
would have to be set.Also: for anyone testing this, we are still waiting on #569 to get merged to fix the width/spacing issue