(exa PR) 1136: Fix #393: add flag to dereference links #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cafkafk
changed the title
Yea, looks like merging is gonna get pretty hairy. I do like how they have introduced a flag and documented it! It does still need completions. |
...and propagate it. Add the `-X`/`--dereference` flags which are used to enable dereferencing through symbolic links, similar to ls's `-L`. Added the `link_target_recurse` method in order to recursively call the existing `link_target` method to get the final target at the end of the chain of links. In order to appropriately display the final output and play nicely with existing functionality, a `deref_links` variable has been added to a few places such that it can be propagated until the time it is needed during rendering. Following commits will use this information to display dereferenced information. Signed-off-by: Christina Sørensen <[email protected]>
Signed-off-by: Christina Sørensen <[email protected]>
Signed-off-by: Christina Sørensen <[email protected]>
Signed-off-by: Christina Sørensen <[email protected]>
Signed-off-by: Christina Sørensen <[email protected]>
Signed-off-by: Christina Sørensen <[email protected]>
Signed-off-by: Christina Sørensen <[email protected]>
Signed-off-by: Christina Sørensen <[email protected]>
This was horrible. Signed-off-by: Christina Sørensen <[email protected]>
Signed-off-by: Christina Sørensen <[email protected]>
|
Can you check this out whenever you have time, it was a pretty big merge so I'd like to get more eyes on whether or not it's correct. |
|
I'm trying it out right now but it seems like it is deref'ing by default and the |
No I can reproduce it :s It shouldn't be hard to fix, I'll open an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ogham/exa#1136
todo: