[TASK] "Out of stock" message improved

* Parantheses included in translation value. * Added parameter to ViewHelper for easy switch whether message shall be shown in select options or not.
extcode · Oct 11, 2024 · ddf73b5 · ddf73b5
1 parent fb265fc
commit ddf73b5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/Classes/ViewHelpers/Form/VariantSelectViewHelper.php b/Classes/ViewHelpers/Form/VariantSelectViewHelper.php
@@ -31,7 +31,9 @@ class VariantSelectViewHelper extends AbstractViewHelper
 
     public function __construct(
         private readonly Context $context,
-    ) {}
+    )
+    {
+    }
 
     /**
      * Initialize arguments.
@@ -53,6 +55,7 @@ public function initializeArguments(): void
         $this->registerArgument('name', 'string', 'name for select');
         $this->registerArgument('blank', 'string', 'blank adds blank option');
         $this->registerArgument('required', 'bool', 'required adds html5 required', false, true);
+        $this->registerArgument('showOutOfStockMessage', 'bool', 'render "out of stock" in select field', false, true);
     }
 
     /**
@@ -167,11 +170,14 @@ protected function getOptions(): array
             $disabled = '';
             if (!$beVariant->getIsAvailable() && $beVariant->getProduct()->isHandleStockInVariants()) {
                 $disabled = 'disabled';
-                $labelOutofStock = LocalizationUtility::translate(
-                    'tx_cartproducts.stock.out_of_stock',
-                    'cart_products'
-                );
-                $optionLabel .= ' (' . $labelOutofStock . ')';
+
+                if ($this->arguments['showOutOfStockMessage']) {
+                    $labelOutofStock = LocalizationUtility::translate(
+                        'tx_cartproducts.stock.out_of_stock',
+                        'cart_products'
+                    );
+                    $optionLabel .= $labelOutofStock;
+                }
             }
 
             if ($beVariant->getProduct()->isHandleStockInVariants()) {

diff --git a/Resources/Private/Language/locallang.xlf b/Resources/Private/Language/locallang.xlf
@@ -215,7 +215,7 @@
 				<source>Not in stock</source>
 			</trans-unit>
 			<trans-unit id="tx_cartproducts.stock.out_of_stock">
-				<source>out of stock</source>
+				<source> (out of stock)</source>
 			</trans-unit>
 
         </body>