Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for Privnet Options. #644

Merged
merged 21 commits into from
Nov 4, 2024

Conversation

arthuraliiev
Copy link
Contributor

@arthuraliiev arthuraliiev commented Oct 18, 2024

Description

./exo compute private-network create test -z ch-gva-2 --dns-server="1.1.1.1" --dns-server="0.0.0.0" --ntp-server="1.1.1.1"
 ✔ Creating Private Network "test"... 3s
┼─────────────────┼──────────────────────────────────────┼
│ PRIVATE NETWORK │                                      │
┼─────────────────┼──────────────────────────────────────┼
│ ID              │ 3bef01a2-98de-4c7b-9c90-8df1ff103c47 │
│ Name            │ test                                 │
│ Description     │                                      │
│ Zone            │ ch-gva-2                             │
│ Type            │ manual                               │
│ Options         │                                      │
│                 │   DNS Servers   1.1.1.1, 0.0.0.0     │
│                 │   NTP Servers   1.1.1.1              │
│                 │                                      │
┼─────────────────┼──────────────────────────────────────┼

./exo compute private-network update test -z ch-gva-2 --dns-server="" --ntp-server="100.100.100.100" --domain-search="hello.com hello.world" --router="0.0.0.0"
 ✔ Updating Private Network ""... 3s
┼─────────────────┼───────────────────────────────────────────┼
│ PRIVATE NETWORK │                                           │
┼─────────────────┼───────────────────────────────────────────┼
│ ID              │ 24b642e0-9728-4b42-b103-a9484d860c1d      │
│ Name            │ test                                      │
│ Description     │                                           │
│ Zone            │ ch-gva-2                                  │
│ Type            │ manual                                    │
│ Options         │                                           │
│                 │   Routers         0.0.0.0                 │
│                 │   NTP Servers     100.100.100.100         │
│                 │   Domain Search   hello.com hello.world   │
│                 │                                           │
┼─────────────────┼───────────────────────────────────────────┼

./exo compute private-network show test
┼─────────────────┼───────────────────────────────────────────┼
│ PRIVATE NETWORK │                                           │
┼─────────────────┼───────────────────────────────────────────┼
│ ID              │ 24b642e0-9728-4b42-b103-a9484d860c1d      │
│ Name            │ test                                      │
│ Description     │                                           │
│ Zone            │ ch-gva-2                                  │
│ Type            │ manual                                    │
│ Options         │                                           │
│                 │   Routers         0.0.0.0                 │
│                 │   NTP Servers     100.100.100.100         │
│                 │   Domain Search   hello.com hello.world   │
│                 │                                           │
┼─────────────────┼───────────────────────────────────────────┼

Checklist

(For exoscale contributors)

  • Changelog updated (under Unreleased block)
  • Testing

Testing

@arthuraliiev arthuraliiev marked this pull request as ready for review October 23, 2024 12:49
@arthuraliiev arthuraliiev force-pushed the aa/sc-107789/cli-to-support-dhcp-options branch from 87adcd1 to ae1eaef Compare October 23, 2024 12:50
@kobajagi
Copy link
Contributor

Thanks @arthuraliiev , looks good.
I'll do another pass tomorrow morning and approve.

@arthuraliiev arthuraliiev force-pushed the aa/sc-107789/cli-to-support-dhcp-options branch from e6ac11f to 688de35 Compare October 30, 2024 10:45
Copy link
Member

@sauterp sauterp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Please update the changelog also,
thanks for the contribution!

Copy link
Member

@pierre-emmanuelJ pierre-emmanuelJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @arthuraliiev :) thank you!

@arthuraliiev arthuraliiev merged commit ad822e9 into master Nov 4, 2024
2 checks passed
@arthuraliiev arthuraliiev deleted the aa/sc-107789/cli-to-support-dhcp-options branch November 4, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants