Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iam-api-key): Update IAM API Key manipulation to egoscale v3 #643

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

mlec1
Copy link
Contributor

@mlec1 mlec1 commented Oct 12, 2024

Description

Update IAM API Key manipulation to egoscale v3

Checklist

(For exoscale contributors)

  • Changelog updated (under Unreleased block)
  • Testing

Testing

Tested locally :

root@c863e81f354a:/exo# go run . iam api-key create test-create-key test-temp-mlec
┼────────┼─────────────────────────────────────────────┼
│ Name   │ test-create-key                             │
│ Key    │ EXO...                                      │
│ Secret │ [REDACTED]                                  │
│ Role   │ 6fa23920-433c-4048-89b5-e3075f23336f        │
┼────────┼─────────────────────────────────────────────┼
root@c863e81f354a:/exo# go run . iam api-key list
┼──────────────────────────────────────┼─────────────────────────────┼─────────────────────────────────────────────────────────────────────────────┼
│                 NAME                 │             KEY             │                                    ROLE                                     │
┼──────────────────────────────────────┼─────────────────────────────┼─────────────────────────────────────────────────────────────────────────────┼
│ test-create-key                      │ EXO492034a8c3a1ab76cc09948e │ test-temp-mlec (6fa23920-433c-4048-89b5-e3075f23336f)                       │
┼──────────────────────────────────────┼─────────────────────────────┼─────────────────────────────────────────────────────────────────────────────┼
root@c863e81f354a:/exo# go run . iam api-key delete test-create-key
[+] Are you sure you want to delete API Key "test-create-key"? [yN]: y
 ✔ Deleting API Key test-create-key... 0s

Copy link
Member

@pierre-emmanuelJ pierre-emmanuelJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!!

Can you update the changelog with the PR name

refactor(iam-api-key): Update IAM API Key manipulation to egoscale v3 #643

And we are good we will merge it

@elkezza elkezza self-requested a review November 5, 2024 12:41
@pierre-emmanuelJ pierre-emmanuelJ merged commit 21f11ca into exoscale:master Nov 5, 2024
1 check passed
@mlec1 mlec1 deleted the update-iam-api-key-v3 branch December 29, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants