Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: handle errors in batch objects delete action #627

Merged

Conversation

kobajagi
Copy link
Contributor

@kobajagi kobajagi commented Aug 5, 2024

Description

Batch objects delete API method from aws-sdk-go-v2 will not return error as second argument if individual objects failed to be deleted. Instead it will return both list of deleted objects and list of errors in result structure.

This prints errors (if any) after the list of successfully deleted files.

Checklist

(For exoscale contributors)

  • Changelog updated (under Unreleased block)
  • Testing

Testing

@kobajagi kobajagi force-pushed the predrag/sc-99100/exo-cli-storage-deleteobjects-error-handling branch from 1863f26 to 249ce04 Compare October 21, 2024 17:06
@kobajagi kobajagi marked this pull request as ready for review October 21, 2024 17:08
pkg/storage/sos/object.go Show resolved Hide resolved
Copy link
Member

@pierre-emmanuelJ pierre-emmanuelJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😃

@kobajagi kobajagi merged commit 405ae2b into master Oct 22, 2024
1 check passed
@kobajagi kobajagi deleted the predrag/sc-99100/exo-cli-storage-deleteobjects-error-handling branch October 22, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants