Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sks nodepool: show instance family #615

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

sauterp
Copy link
Member

@sauterp sauterp commented Jun 28, 2024

Checklist

(For exoscale contributors)

  • Changelog updated (under Unreleased block)
  • Testing

Testing

❯ ./bin/exo -A exosauterp compute sks nodepool show abc def -z ch-gva-2
┼─────────────────────────┼──────────────────────────────────────┼
│      SKS NODEPOOL       │                                      │
┼─────────────────────────┼──────────────────────────────────────┼
│ Instance Type           │ standard.medium                      │
┼─────────────────────────┼──────────────────────────────────────┼

@sauterp sauterp marked this pull request as ready for review June 28, 2024 08:15
@horakg
Copy link

horakg commented Jun 28, 2024

Will it be shown like this:
Instance Type │ cpu.extra-large

or will we get two lines like above, currently we always show "." in all other outputs

@sauterp
Copy link
Member Author

sauterp commented Jun 28, 2024

Will it be shown like this: Instance Type │ cpu.extra-large

or will we get two lines like above, currently we always show "." in all other outputs

I changed it to be consistent with other show commands. The output is as shown in the PR description.

@sauterp sauterp merged commit 9aa7e88 into master Jul 3, 2024
2 checks passed
@sauterp sauterp deleted the philippsauter/sks-nodepool-show-instance-family branch July 3, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants