fix: Improve error message

exoscale · Dec 29, 2024 · b41a6d8 · b41a6d8
1 parent ee8348d
commit b41a6d8
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/cmd/elastic_ip_create.go b/cmd/elastic_ip_create.go
@@ -94,7 +94,11 @@ func (c *elasticIPCreateCmd) cmdRun(_ *cobra.Command, _ []string) error {
 		}
 
 		_, err = client.Wait(ctx, op, v3.OperationStateSuccess)
-		return err
+		if err != nil {
+			return fmt.Errorf("exoscale: error while waiting for Elastic IP creation: %w", err)
+		}
+
+		return nil
 	})
 	if err != nil {
 		return err

diff --git a/cmd/elastic_ip_delete.go b/cmd/elastic_ip_delete.go
@@ -67,7 +67,11 @@ func (c *elasticIPDeleteCmd) cmdRun(_ *cobra.Command, _ []string) error {
 		}
 
 		_, err = client.Wait(ctx, op, v3.OperationStateSuccess)
-		return err
+		if err != nil {
+			return fmt.Errorf("exoscale: error while waiting for Elastic IP deletion: %w", err)
+		}
+
+		return nil
 	})
 }
 

diff --git a/cmd/elastic_ip_show.go b/cmd/elastic_ip_show.go
@@ -152,9 +152,6 @@ func (c *elasticIPShowCmd) cmdRun(_ *cobra.Command, _ []string) error {
 
 	if elasticIP.Healthcheck != nil {
 		out.Type = "managed"
-		// Message for reviewer:
-		// I don't really like to use this function for only one this parameter, if you have a better solution, please feel free to suggest it
-		// TODO: remove comment before merging
 		out.HealthcheckMode = utils.NonEmptyStringPtr(string(elasticIP.Healthcheck.Mode))
 		out.HealthcheckPort = &elasticIP.Healthcheck.Port
 		out.HealthcheckURI = &elasticIP.Healthcheck.URI