Skip to content

Commit

Permalink
dbaas: database management for mysql, pg (#661)
Browse files Browse the repository at this point in the history 
# Description
<!--
* Prefix: the title with the component name being changed. Add a short
and self describing sentence to ease the review
* Please add a few lines providing context and describing the change
* Please self comment changes whenever applicable to help with the
review process
* Please keep the checklist as part of the PR. Tick what applies to this
change.
-->

Allows users to use the CLI to directly automate database creation for
selected services

Also includes a few check before creating users for DBAAS service to
verify if the service is ready to accept user creation


## Checklist
(For exoscale contributors)

* [x] Changelog updated (under *Unreleased* block)
* [x] Testing

## Testing

<!--
Describe the tests you did
-->
```
➜  ~/exo/cli git:(tgrondier/sc-114061/dbaas-support-for-mysql-posgres-database) go run . dbaas create pg hobbyist-2 test-pg                                                                                                                                                                                 25-01-09 12:18 
 ✔ Creating Database Service "test-pg"... 0s
┼───────────────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼
│   DATABASE SERVICE    │                                                                                                                                  │
┼───────────────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼
│ Zone                  │ de-muc-1                                                                                                                         │
│ Name                  │ test-pg                                                                                                                          │
│ Type                  │ pg                                                                                                                               │
│ Plan                  │ hobbyist-2                                                                                                                       │
│ Disk Size             │ 8.0 GiB                                                                                                                          │
│ State                 │ rebuilding                                                                                                                       │
│ Creation Date         │ 2025-01-09 11:18:44 +0000 UTC                                                                                                    │
│ Update Date           │ 2025-01-09 11:18:44 +0000 UTC                                                                                                    │
│ Nodes                 │ 1                                                                                                                                │
│ Node CPUs             │ 2                                                                                                                                │
│ Node Memory           │ 2.0 GiB                                                                                                                          │
│ Termination Protected │ true                                                                                                                             │
│ Maintenance           │ saturday (02:51:27)                                                                                                              │
│ Version               │ 16                                                                                                                               │
│ Backup Schedule       │ 10:51                                                                                                                            │
│ URI                   │ postgres://avnadmin:xxxxx@test-pg-exoscale-6b703a50-10bb-400c-bd87-2cd1ad11d7f9.h.aivencloud.com:21699/defaultdb?sslmode=require │
│ IP Filter             │                                                                                                                                  │
│ Components            │                                                                                                                                  │
│                       │   pgbouncer   test-pg-exoscale-6b703a50-10bb-400c-bd87-2cd1ad11d7f9.h.aivencloud.com:21700   route:dynamic   usage:primary       │
│                       │   pg          test-pg-exoscale-6b703a50-10bb-400c-bd87-2cd1ad11d7f9.h.aivencloud.com:21699   route:dynamic   usage:primary       │
│                       │                                                                                                                                  │
│ Users                 │ n/a                                                                                                                              │
│ Databases             │                                                                                                                                  │
┼───────────────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼
➜  ~/exo/cli git:(tgrondier/sc-114061/dbaas-support-for-mysql-posgres-database) go run . dbaas create mysql hobbyist-2 test                                                                                                                                                                                 25-01-09 12:18 
 ✔ Creating Database Service "test"... 1s
┼───────────────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼
│   DATABASE SERVICE    │                                                                                                                              │
┼───────────────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼
│ Zone                  │ de-muc-1                                                                                                                     │
│ Name                  │ test                                                                                                                         │
│ Type                  │ mysql                                                                                                                        │
│ Plan                  │ hobbyist-2                                                                                                                   │
│ Disk Size             │ 8.0 GiB                                                                                                                      │
│ State                 │ rebuilding                                                                                                                   │
│ Creation Date         │ 2025-01-09 11:18:51 +0000 UTC                                                                                                │
│ Update Date           │ 2025-01-09 11:18:51 +0000 UTC                                                                                                │
│ Nodes                 │ 1                                                                                                                            │
│ Node CPUs             │ 2                                                                                                                            │
│ Node Memory           │ 2.0 GiB                                                                                                                      │
│ Termination Protected │ true                                                                                                                         │
│ Maintenance           │ sunday (02:45:14)                                                                                                            │
│ Version               │ 8                                                                                                                            │
│ Backup Schedule       │ 15:17                                                                                                                        │
│ URI                   │ mysql://avnadmin:xxxxx@test-exoscale-6b703a50-10bb-400c-bd87-2cd1ad11d7f9.h.aivencloud.com:21699/defaultdb?ssl-mode=REQUIRED │
│ IP Filter             │                                                                                                                              │
│ Components            │                                                                                                                              │
│                       │   mysqlx   test-exoscale-6b703a50-10bb-400c-bd87-2cd1ad11d7f9.h.aivencloud.com:21703   route:dynamic   usage:primary         │
│                       │   mysql    test-exoscale-6b703a50-10bb-400c-bd87-2cd1ad11d7f9.h.aivencloud.com:21699   route:dynamic   usage:primary         │
│                       │                                                                                                                              │
│ Users                 │ n/a                                                                                                                          │
│ Databases             │                                                                                                                              │
┼───────────────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼
➜  ~/exo/cli git:(tgrondier/sc-114061/dbaas-support-for-mysql-posgres-database) exo dbaas delete test -f                                                                                                                                                                                                    25-01-09 12:18 
➜  ~/exo/cli git:(tgrondier/sc-114061/dbaas-support-for-mysql-posgres-database) go run . dbaas database create test-pg blz                                                                                                                                                                                  25-01-09 12:18 
error: service "test-pg" is not ready for database creation
exit status 1
➜  ~/exo/cli git:(tgrondier/sc-114061/dbaas-support-for-mysql-posgres-database) go run . dbaas database create test blz                                                                                                                                                                                     25-01-09 12:19 
error: service "test" is not ready for database creation
exit status 1
➜  ~/exo/cli git:(tgrondier/sc-114061/dbaas-support-for-mysql-posgres-database) go run . dbaas database create test-pg blz                                                                                                                                                                                  25-01-09 12:19 
 ✔ Creating DBaaS database "blz" 0s
┼───────────────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼
│   DATABASE SERVICE    │                                                                                                                                  │
┼───────────────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼
│ Zone                  │ de-muc-1                                                                                                                         │
│ Name                  │ test-pg                                                                                                                          │
│ Type                  │ pg                                                                                                                               │
│ Plan                  │ hobbyist-2                                                                                                                       │
│ Disk Size             │ 8.0 GiB                                                                                                                          │
│ State                 │ running                                                                                                                          │
│ Creation Date         │ 2025-01-09 11:18:44 +0000 UTC                                                                                                    │
│ Update Date           │ 2025-01-09 11:21:03 +0000 UTC                                                                                                    │
│ Nodes                 │ 1                                                                                                                                │
│ Node CPUs             │ 2                                                                                                                                │
│ Node Memory           │ 2.0 GiB                                                                                                                          │
│ Termination Protected │ true                                                                                                                             │
│ Maintenance           │ saturday (02:51:27)                                                                                                              │
│ Version               │ 16.6                                                                                                                             │
│ Backup Schedule       │ 10:51                                                                                                                            │
│ URI                   │ postgres://avnadmin:xxxxx@test-pg-exoscale-6b703a50-10bb-400c-bd87-2cd1ad11d7f9.h.aivencloud.com:21699/defaultdb?sslmode=require │
│ IP Filter             │                                                                                                                                  │
│ Components            │                                                                                                                                  │
│                       │   pgbouncer   test-pg-exoscale-6b703a50-10bb-400c-bd87-2cd1ad11d7f9.h.aivencloud.com:21700   route:dynamic   usage:primary       │
│                       │   pg          test-pg-exoscale-6b703a50-10bb-400c-bd87-2cd1ad11d7f9.h.aivencloud.com:21699   route:dynamic   usage:primary       │
│                       │                                                                                                                                  │
│ Users                 │ avnadmin (primary)                                                                                                               │
│ Databases             │ blz                                                                                                                              │
│                       │ defaultdb                                                                                                                        │
┼───────────────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼
➜  ~/exo/cli git:(tgrondier/sc-114061/dbaas-support-for-mysql-posgres-database) go run . dbaas database create test-pg blz                                                                                                                                                                                  25-01-09 12:21 
error: CreateDBAASPGDatabase: http response: Conflict: Service database 'blz' already exists
exit status 1
➜  ~/exo/cli git:(tgrondier/sc-114061/dbaas-support-for-mysql-posgres-database) go run . dbaas database delete test-pg blz                                                                                                                                                                                  25-01-09 12:21 
[+] Are you sure you want to delete database "blz" [yN]: y
 ✔ Deleting DBaaS database "blz" 0s
┼───────────────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼
│   DATABASE SERVICE    │                                                                                                                                  │
┼───────────────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼
│ Zone                  │ de-muc-1                                                                                                                         │
│ Name                  │ test-pg                                                                                                                          │
│ Type                  │ pg                                                                                                                               │
│ Plan                  │ hobbyist-2                                                                                                                       │
│ Disk Size             │ 8.0 GiB                                                                                                                          │
│ State                 │ running                                                                                                                          │
│ Creation Date         │ 2025-01-09 11:18:44 +0000 UTC                                                                                                    │
│ Update Date           │ 2025-01-09 11:21:17 +0000 UTC                                                                                                    │
│ Nodes                 │ 1                                                                                                                                │
│ Node CPUs             │ 2                                                                                                                                │
│ Node Memory           │ 2.0 GiB                                                                                                                          │
│ Termination Protected │ true                                                                                                                             │
│ Maintenance           │ saturday (02:51:27)                                                                                                              │
│ Version               │ 16.6                                                                                                                             │
│ Backup Schedule       │ 10:51                                                                                                                            │
│ URI                   │ postgres://avnadmin:xxxxx@test-pg-exoscale-6b703a50-10bb-400c-bd87-2cd1ad11d7f9.h.aivencloud.com:21699/defaultdb?sslmode=require │
│ IP Filter             │                                                                                                                                  │
│ Components            │                                                                                                                                  │
│                       │   pgbouncer   test-pg-exoscale-6b703a50-10bb-400c-bd87-2cd1ad11d7f9.h.aivencloud.com:21700   route:dynamic   usage:primary       │
│                       │   pg          test-pg-exoscale-6b703a50-10bb-400c-bd87-2cd1ad11d7f9.h.aivencloud.com:21699   route:dynamic   usage:primary       │
│                       │                                                                                                                                  │
│ Users                 │ avnadmin (primary)                                                                                                               │
│ Databases             │ defaultdb                                                                                                                        │
┼───────────────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼
➜  ~/exo/cli git:(tgrondier/sc-114061/dbaas-support-for-mysql-posgres-database) go run . dbaas database create test blz                                                                                                                                                                                     25-01-09 12:21 
 ✔ Creating DBaaS database "blz" 0s
┼───────────────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼
│   DATABASE SERVICE    │                                                                                                                              │
┼───────────────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼
│ Zone                  │ de-muc-1                                                                                                                     │
│ Name                  │ test                                                                                                                         │
│ Type                  │ mysql                                                                                                                        │
│ Plan                  │ hobbyist-2                                                                                                                   │
│ Disk Size             │ 8.0 GiB                                                                                                                      │
│ State                 │ running                                                                                                                      │
│ Creation Date         │ 2025-01-09 11:18:51 +0000 UTC                                                                                                │
│ Update Date           │ 2025-01-09 11:21:22 +0000 UTC                                                                                                │
│ Nodes                 │ 1                                                                                                                            │
│ Node CPUs             │ 2                                                                                                                            │
│ Node Memory           │ 2.0 GiB                                                                                                                      │
│ Termination Protected │ true                                                                                                                         │
│ Maintenance           │ sunday (02:45:14)                                                                                                            │
│ Version               │ 8.0.30                                                                                                                       │
│ Backup Schedule       │ 15:17                                                                                                                        │
│ URI                   │ mysql://avnadmin:xxxxx@test-exoscale-6b703a50-10bb-400c-bd87-2cd1ad11d7f9.h.aivencloud.com:21699/defaultdb?ssl-mode=REQUIRED │
│ IP Filter             │                                                                                                                              │
│ Components            │                                                                                                                              │
│                       │   mysqlx   test-exoscale-6b703a50-10bb-400c-bd87-2cd1ad11d7f9.h.aivencloud.com:21703   route:dynamic   usage:primary         │
│                       │   mysql    test-exoscale-6b703a50-10bb-400c-bd87-2cd1ad11d7f9.h.aivencloud.com:21699   route:dynamic   usage:primary         │
│                       │                                                                                                                              │
│ Users                 │ avnadmin (primary)                                                                                                           │
│ Databases             │ blz                                                                                                                          │
│                       │ defaultdb                                                                                                                    │
┼───────────────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼
➜  ~/exo/cli git:(tgrondier/sc-114061/dbaas-support-for-mysql-posgres-database) go run . dbaas database delete test-pg blz -f                                                                                                                                                                               25-01-09 12:21 
error: database "blz" not found for service "test-pg"
exit status 1
➜  ~/exo/cli git:(tgrondier/sc-114061/dbaas-support-for-mysql-posgres-database) go run . dbaas database delete test blz -f                                                                                                                                                                                  25-01-09 12:21 
 ✔ Deleting DBaaS database "blz" 0s
┼───────────────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼
│   DATABASE SERVICE    │                                                                                                                              │
┼───────────────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼
│ Zone                  │ de-muc-1                                                                                                                     │
│ Name                  │ test                                                                                                                         │
│ Type                  │ mysql                                                                                                                        │
│ Plan                  │ hobbyist-2                                                                                                                   │
│ Disk Size             │ 8.0 GiB                                                                                                                      │
│ State                 │ running                                                                                                                      │
│ Creation Date         │ 2025-01-09 11:18:51 +0000 UTC                                                                                                │
│ Update Date           │ 2025-01-09 11:21:32 +0000 UTC                                                                                                │
│ Nodes                 │ 1                                                                                                                            │
│ Node CPUs             │ 2                                                                                                                            │
│ Node Memory           │ 2.0 GiB                                                                                                                      │
│ Termination Protected │ true                                                                                                                         │
│ Maintenance           │ sunday (02:45:14)                                                                                                            │
│ Version               │ 8.0.30                                                                                                                       │
│ Backup Schedule       │ 15:17                                                                                                                        │
│ URI                   │ mysql://avnadmin:xxxxx@test-exoscale-6b703a50-10bb-400c-bd87-2cd1ad11d7f9.h.aivencloud.com:21699/defaultdb?ssl-mode=REQUIRED │
│ IP Filter             │                                                                                                                              │
│ Components            │                                                                                                                              │
│                       │   mysqlx   test-exoscale-6b703a50-10bb-400c-bd87-2cd1ad11d7f9.h.aivencloud.com:21703   route:dynamic   usage:primary         │
│                       │   mysql    test-exoscale-6b703a50-10bb-400c-bd87-2cd1ad11d7f9.h.aivencloud.com:21699   route:dynamic   usage:primary         │
│                       │                                                                                                                              │
│ Users                 │ avnadmin (primary)                                                                                                           │
│ Databases             │ defaultdb                                                                                                                    │
┼───────────────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼
```
  • Loading branch information
@tgrondier
tgrondier authored Jan 10, 2025
1 parent bb74bd1 commit 52e8505
Show file tree
Hide file tree
Showing 17 changed files with 478 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- storage: Adding recursive feature to the storage command #653
- Update help for instance protection #658
- dbaas: database management for mysql, pg #661

### Bug fixes

Expand Down
14 changes: 14 additions & 0 deletions cmd/dbaas_database.go
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package cmd

import (
"github.com/spf13/cobra"
)

var dbaasDatabaseCmd = &cobra.Command{
Use: "database",
Short: "Manage DBaaS databases",
}

func init() {
dbaasCmd.AddCommand(dbaasDatabaseCmd)
}
72 changes: 72 additions & 0 deletions cmd/dbaas_database_create.go
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
package cmd

import (
"fmt"
"os"

"github.com/spf13/cobra"
)

type dbaasDatabaseCreateCmd struct {
cliCommandSettings `cli-cmd:"-"`

_ bool `cli-cmd:"create"`

Name string `cli-arg:"#"`
Database string `cli-arg:"#"`

HelpPg bool `cli-usage:"show usage for flags specific to the pg type"`
Zone string `cli-short:"z" cli-usage:"Database Service zone"`

// "pg" type specific flags
PgLcCollate string `cli-usage:"Default string sort order (LC_COLLATE) for PostgreSQL database" cli-hidden:""`
PgLcCtype string `cli-usage:"Default character classification (LC_CTYPE) for PostgreSQL database" cli-hidden:""`
}

func (c *dbaasDatabaseCreateCmd) cmdAliases() []string { return nil }

func (c *dbaasDatabaseCreateCmd) cmdShort() string { return "Create DBAAS database" }

func (c *dbaasDatabaseCreateCmd) cmdLong() string {
return `This command creates a DBAAS database for the specified service.`
}

func (c *dbaasDatabaseCreateCmd) cmdPreRun(cmd *cobra.Command, args []string) error {
switch {

case cmd.Flags().Changed("help-mysql"):
cmdShowHelpFlags(cmd.Flags(), "mysql-")
os.Exit(0)
case cmd.Flags().Changed("help-pg"):
cmdShowHelpFlags(cmd.Flags(), "pg-")
os.Exit(0)
}

cmdSetZoneFlagFromDefault(cmd)
return cliCommandDefaultPreRun(c, cmd, args)
}

func (c *dbaasDatabaseCreateCmd) cmdRun(cmd *cobra.Command, args []string) error {

ctx := gContext
db, err := dbaasGetV3(ctx, c.Name, c.Zone)
if err != nil {
return err
}

switch db.Type {
case "mysql":
return c.createMysql(cmd, args)
case "pg":
return c.createPg(cmd, args)
default:
return fmt.Errorf("creating database unsupported for service of type %q", db.Type)
}

}

func init() {
cobra.CheckErr(registerCLICommand(dbaasDatabaseCmd, &dbaasDatabaseCreateCmd{
cliCommandSettings: defaultCLICmdSettings(),
}))
}
55 changes: 55 additions & 0 deletions cmd/dbaas_database_create_mysql.go
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
package cmd

import (
"fmt"

"github.com/exoscale/cli/pkg/account"
"github.com/exoscale/cli/pkg/globalstate"
exoapi "github.com/exoscale/egoscale/v2/api"
v3 "github.com/exoscale/egoscale/v3"
"github.com/spf13/cobra"
)

func (c dbaasDatabaseCreateCmd) createMysql(cmd *cobra.Command, _ []string) error {

ctx := gContext

client, err := switchClientZoneV3(ctx, globalstate.EgoscaleV3Client, v3.ZoneName(c.Zone))
if err != nil {
return err
}

s, err := client.GetDBAASServiceMysql(ctx, c.Name)
if err != nil {
return err
}

if len(s.Databases) == 0 {
return fmt.Errorf("service %q is not ready for database creation", c.Name)
}

req := v3.CreateDBAASMysqlDatabaseRequest{
DatabaseName: v3.DBAASDatabaseName(c.Database),
}

op, err := client.CreateDBAASMysqlDatabase(ctx, c.Name, req)
if err != nil {
return err
}

decorateAsyncOperation(fmt.Sprintf("Creating DBaaS database %q", c.Database), func() {
op, err = client.Wait(ctx, op, v3.OperationStateSuccess)
})
if err != nil {
return err
}

if !globalstate.Quiet {
return c.outputFunc((&dbaasServiceShowCmd{
Name: c.Name,
Zone: c.Zone,
}).showDatabaseServiceMysql(exoapi.WithEndpoint(gContext, exoapi.NewReqEndpoint(account.CurrentAccount.Environment, c.Zone))))
}

return err
}
61 changes: 61 additions & 0 deletions cmd/dbaas_database_create_pg.go
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
package cmd

import (
"fmt"

"github.com/exoscale/cli/pkg/account"
"github.com/exoscale/cli/pkg/globalstate"
exoapi "github.com/exoscale/egoscale/v2/api"
v3 "github.com/exoscale/egoscale/v3"
"github.com/spf13/cobra"
)

func (c dbaasDatabaseCreateCmd) createPg(cmd *cobra.Command, _ []string) error {
ctx := gContext

client, err := switchClientZoneV3(ctx, globalstate.EgoscaleV3Client, v3.ZoneName(c.Zone))
if err != nil {
return err
}
s, err := client.GetDBAASServicePG(ctx, c.Name)
if err != nil {
return err
}

if len(s.Databases) == 0 {
return fmt.Errorf("service %q is not ready for database creation", c.Name)
}

req := v3.CreateDBAASPGDatabaseRequest{
DatabaseName: v3.DBAASDatabaseName(c.Database),
}

if c.PgLcCollate != "" {
req.LCCollate = c.PgLcCollate
}

if c.PgLcCtype != "" {
req.LCCtype = c.PgLcCtype
}

op, err := client.CreateDBAASPGDatabase(ctx, c.Name, req)
if err != nil {
return err
}

decorateAsyncOperation(fmt.Sprintf("Creating DBaaS database %q", c.Database), func() {
op, err = client.Wait(ctx, op, v3.OperationStateSuccess)
})
if err != nil {
return err
}

if !globalstate.Quiet {
return c.outputFunc((&dbaasServiceShowCmd{
Name: c.Name,
Zone: c.Zone,
}).showDatabaseServicePG(exoapi.WithEndpoint(gContext, exoapi.NewReqEndpoint(account.CurrentAccount.Environment, c.Zone))))
}

return err
}
59 changes: 59 additions & 0 deletions cmd/dbaas_database_delete.go
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
package cmd

import (
"fmt"

"github.com/spf13/cobra"
)

type dbaasDatabaseDeleteCmd struct {
cliCommandSettings `cli-cmd:"-"`

_ bool `cli-cmd:"delete"`

Name string `cli-arg:"#"`
Database string `cli-arg:"#"`

Zone string `cli-short:"z" cli-usage:"Database Service zone"`

Force bool `cli-short:"f" cli-usage:"don't prompt for confirmation"`
}

func (c *dbaasDatabaseDeleteCmd) cmdAliases() []string { return nil }

func (c *dbaasDatabaseDeleteCmd) cmdShort() string { return "Delete DBAAS database" }

func (c *dbaasDatabaseDeleteCmd) cmdLong() string {
return `This command deletes a DBAAS database for the specified service.`
}

func (c *dbaasDatabaseDeleteCmd) cmdPreRun(cmd *cobra.Command, args []string) error {

cmdSetZoneFlagFromDefault(cmd)
return cliCommandDefaultPreRun(c, cmd, args)
}

func (c *dbaasDatabaseDeleteCmd) cmdRun(cmd *cobra.Command, args []string) error {

ctx := gContext
db, err := dbaasGetV3(ctx, c.Name, c.Zone)
if err != nil {
return err
}

switch db.Type {
case "mysql":
return c.deleteMysql(cmd, args)
case "pg":
return c.deletePg(cmd, args)
default:
return fmt.Errorf("creating database unsupported for service of type %q", db.Type)
}

}

func init() {
cobra.CheckErr(registerCLICommand(dbaasDatabaseCmd, &dbaasDatabaseDeleteCmd{
cliCommandSettings: defaultCLICmdSettings(),
}))
}
64 changes: 64 additions & 0 deletions cmd/dbaas_database_delete_mysql.go
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
package cmd

import (
"fmt"

"github.com/exoscale/cli/pkg/account"
"github.com/exoscale/cli/pkg/globalstate"
exoapi "github.com/exoscale/egoscale/v2/api"
v3 "github.com/exoscale/egoscale/v3"
"github.com/spf13/cobra"
)

func (c dbaasDatabaseDeleteCmd) deleteMysql(cmd *cobra.Command, _ []string) error {
ctx := gContext

client, err := switchClientZoneV3(ctx, globalstate.EgoscaleV3Client, v3.ZoneName(c.Zone))
if err != nil {
return err
}

s, err := client.GetDBAASServiceMysql(ctx, c.Name)
if err != nil {
return err
}

dbFound := false
for _, db := range s.Databases {
if db == v3.DBAASMysqlDatabaseName(c.Database) {
dbFound = true
break
}
}

if !dbFound {
return fmt.Errorf("database %q not found for service %q", c.Database, c.Name)
}
if !c.Force {
if !askQuestion(fmt.Sprintf(
"Are you sure you want to delete database %q", c.Database)) {
return nil
}
}

op, err := client.DeleteDBAASMysqlDatabase(ctx, c.Name, c.Database)
if err != nil {
return err
}

decorateAsyncOperation(fmt.Sprintf("Deleting DBaaS database %q", c.Database), func() {
op, err = client.Wait(ctx, op, v3.OperationStateSuccess)
})
if err != nil {
return err
}

if !globalstate.Quiet {
return c.outputFunc((&dbaasServiceShowCmd{
Name: c.Name,
Zone: c.Zone,
}).showDatabaseServiceMysql(exoapi.WithEndpoint(gContext, exoapi.NewReqEndpoint(account.CurrentAccount.Environment, c.Zone))))
}

return err
}
Loading

0 comments on commit 52e8505

Please sign in to comment.