Import ShapedArray from jax.core instead for jax.abstract_arrays
#91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I'm going to merge and let's just remove PyMC4 support over in #89. Thanks!! |
dfm
added a commit
that referenced
this pull request
Nov 1, 2023
* Create pymc (>=5) backend Copied pymc4 stuff, renamted aesara to pytensor, and fixed missing/renamed modules * Change broadcastable keyword to shape, but leave note about potential future change * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Import ShapedArray from `jax.core` instead for `jax.abstract_arrays` (#91) * Import ShapedArray from `jax.core` instead for `jax.abstract_arrays` Related JAX changelog: https://jax.readthedocs.io/en/latest/changelog.html#jax-0-4-16-sept-18-2023 * Fixing another deprecated function call --------- Co-authored-by: Dan Foreman-Mackey <[email protected]> * [pre-commit.ci] pre-commit autoupdate (#93) updates: - [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v4.5.0](pre-commit/pre-commit-hooks@v4.4.0...v4.5.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Bump pypa/cibuildwheel from 2.15.0 to 2.16.2 (#92) Bumps [pypa/cibuildwheel](https://github.com/pypa/cibuildwheel) from 2.15.0 to 2.16.2. - [Release notes](https://github.com/pypa/cibuildwheel/releases) - [Changelog](https://github.com/pypa/cibuildwheel/blob/main/docs/changelog.md) - [Commits](pypa/cibuildwheel@v2.15.0...v2.16.2) --- updated-dependencies: - dependency-name: pypa/cibuildwheel dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * adding tests for pymc to CI * Replace pymc4 by pymc in noxfile * Add more comments about shape/broadcastable * Fix typo in PyTensor shape explanation * Update xarray version limit for comparison environment * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Tighter xarray limit --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dan Foreman-Mackey <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dan F-M <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90.
Related JAX changelog: https://jax.readthedocs.io/en/latest/changelog.html#jax-0-4-16-sept-18-2023.