Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment pytensor.config.compute_test_value = "raise" #94

Merged
merged 6 commits into from
Nov 20, 2023

Conversation

vandalt
Copy link
Contributor

@vandalt vandalt commented Nov 13, 2023

PyMC 5.9.2 has been released with a fix, so this no longer crashes test_marginal. Fixes #93.

@dfm
Copy link
Member

dfm commented Nov 13, 2023

Thanks! Do you know why the tests are failing?

Should we add a lower bound here too:

"pymc": ["pymc>=5"],

@vandalt
Copy link
Contributor Author

vandalt commented Nov 15, 2023

I updated the lower bound!

I don't know why the tests are failing. They run fine locally, but there is some compilation error on the Github test environment. I ran them locally on Linux with venv, openblas, and I tried Python 3.10 and 3.11.

FAILED python/test/pymc/test_pymc_celerite2.py::test_consistency[10.5-RotationTerm-args6] - ImportError: /home/runner/.pytensor/compiledir_Linux-6.2--azure-x86_64-with-glibc2.35-x86_64-3.10.13-64/tmp5a7fpkjc/me5764f3d0dadd4197faacbf8742b57837127a6f6bbd36ab7bacfb70bd48fd2b0.so: undefined symbol: dgemm_

I the tests are running with the numpy C-API, which would be the main difference with my local setup I think.

WARNING (pytensor.tensor.blas): Using NumPy C-API based implementation for BLAS functions.

@vandalt
Copy link
Contributor Author

vandalt commented Nov 15, 2023

I'll try installing with mamba to see if the issue still happens (suggestion from @bmorris3)

EDIT: Reverted because mamba is not available on the testing/workflow machines

@dfm
Copy link
Member

dfm commented Nov 20, 2023

Looks like using a conda/mamba env does the trick, but this also points to a bug introduced in the most recent PyMC/Pytensor release (classic!) since it worked previously with pip!

I don't like using mamba for this cause it's still far slower than the pip version, but we do what we need to these days :/

@dfm dfm merged commit 863c472 into exoplanet-dev:main Nov 20, 2023
6 checks passed
@dfm
Copy link
Member

dfm commented Nov 20, 2023

Thanks again for all your work on this, @vandalt!

@vandalt vandalt deleted the pymc-compute-test-value branch March 1, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncomment pytensor.config.compute_test_value = "raise" in conftest.py`
2 participants