-
-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add markdownlint workflow #1903
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"default": false, | ||
"heading-increment": true, | ||
"first-line-heading": true, | ||
"heading-style": "atx" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
name: CI | ||
|
||
on: | ||
push: | ||
paths: | ||
- "**.md" | ||
branches: | ||
- "main" | ||
pull_request: | ||
paths: | ||
- "**.md" | ||
branches: | ||
- "main" | ||
|
||
jobs: | ||
mdlint: | ||
name: Lint Markdown | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # 2.3.4 | ||
|
||
- name: Run markdownlint | ||
uses: nosborn/github-action-markdown-cli@9fc95163471d6460c35cccad13645912aaa25d5f # 1.1.1 | ||
with: | ||
files: "." | ||
config_file: ".github/markdownlint.json" | ||
ignore_files: "analyzer-comments/*" | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,53 +1,55 @@ | ||
### [Website]- Add ability to change which solutions are published: | ||
# Changelog | ||
|
||
## [Website]- Add ability to change which solutions are published: | ||
|
||
Previously, you could not change which solutions are published. We have now enabled this along with the ability to choose which appear on the profile and which allow public comments. [#4163](https://github.com/exercism/exercism/issues/4163) | ||
|
||
### [Website] Add communal mentoring notes | ||
## [Website] Add communal mentoring notes | ||
We have exposed the communal mentoring notes from GitHub to be visible directly within the UI. | ||
|
||
### [Teams] Launch the site | ||
## [Teams] Launch the site | ||
|
||
We have built a dedicated site for teams. It allows groups of people to complete exercises and mentor each other in a private space. We envision it being used by bootcamps, groups of friends, and colleagues at work. | ||
|
||
### [Website] Delete my account | ||
## [Website] Delete my account | ||
|
||
We needed to give people the ability to delete their account without emailing Jeremy. | ||
|
||
### [Website] Reset CLI token | ||
## [Website] Reset CLI token | ||
|
||
We wanted to let people reset their CLI tokens in case they are leaked. [#4150](https://github.com/exercism/exercism/issues/4150) | ||
|
||
### [Website] Improve experience of "Legacy" or "Practice" solutions in Mentored Mode | ||
## [Website] Improve experience of "Legacy" or "Practice" solutions in Mentored Mode | ||
|
||
Have separate restricted queues for core and side exercises when importing solutions created in v1 or in Practice Mode. | ||
|
||
### [Website] Make side-exercise mentoring opt-in: | ||
## [Website] Make side-exercise mentoring opt-in: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Colon at end of headings are not needed. Just spotted a lot of these further down this change and the pedant grammarian in me is crying 🤣 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, just recalled this is still in draft; I'll stop now! |
||
|
||
At the moment some tracks have thousands of side-exercises in the backlog. We're going to change this behaviour so people have to opt-in to mentoring on an exercise-by-exercise basis and can only request mentoring on a handful of exercises at once. | ||
|
||
### [Website] Put challenge back to mentor queue if mentor leaves conversation: | ||
## [Website] Put challenge back to mentor queue if mentor leaves conversation: | ||
[#4308](https://github.com/exercism/exercism/issues/4308) | ||
|
||
### [Website] Merge mentoring.exercism.io into the main site | ||
## [Website] Merge mentoring.exercism.io into the main site | ||
|
||
We wanted to streamline the sign up process, to remove the Google Form and the need to join slack to mentor. This is the first step in a long list of changes we'll make to the mentoring onboarding process. | ||
|
||
### [Website] Make the site responsive. | ||
## [Website] Make the site responsive. | ||
|
||
The Exercism website is now mobile-responsive thanks to this [huge Pull Request](https://github.com/exercism/website/pull/252) by [@jackhughesweb](https://github.com/jackhughesweb).. | ||
|
||
### [Website] Add all notifications | ||
## [Website] Add all notifications | ||
|
||
Marked a notification as read but want to still see it? We've added a button for "All notifications" that allows you to see both read and unread notifications. Credit to [@PatrickMcSweeny](https://github.com/PatrickMcSweeny). | ||
|
||
### [Website] Comments auto-save as typed | ||
## [Website] Comments auto-save as typed | ||
|
||
Nothing is more frustrating than losing your work. To stop accidental tab-closes or refreshes, we've added autosaving as you type comments. Simply go back to the page and you'll find your text is still there!. Credit to [@jackhughesweb](https://github.com/jackhughesweb). | ||
|
||
### [Website] Added Dark Theme to the code editor | ||
## [Website] Added Dark Theme to the code editor | ||
|
||
We have added a dark theme to the code editor. You can enable it in [your preferences](https://exercism.io/my/settings/preferences/edit). Credit to [@jackhughesweb](https://github.com/jackhughesweb). | ||
|
||
### [Tracks] Merged the Javascript and ECMAScript tracks | ||
## [Tracks] Merged the Javascript and ECMAScript tracks | ||
|
||
We merged the Javascript and ECMAScript tracks with the aim of focussing the work of the maintainers and mentors into one place, and improve the quality of our offering. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,22 @@ | ||
### Introduction | ||
# Code of Conduct | ||
|
||
## Introduction | ||
|
||
Exercism is a platform centered around empathetic conversation. We have a low tolerance for communication that makes anyone feel unwelcome, unsupported, insulted or discriminated against. | ||
|
||
### Seen or experienced something uncomfortable? | ||
## Seen or experienced something uncomfortable? | ||
|
||
If you see or experience abuse, harassment, discrimination, or feel unsafe or upset, please email [email protected]. We will take your report seriously. | ||
|
||
### Enforcement | ||
## Enforcement | ||
|
||
We actively monitor for Code of Conduct (CoC) violations and take any reports of violations extremely seriously. We have banned contributors, mentors and users due to violations. | ||
|
||
After we receive a report of a CoC violation, we view that person's conversation history on Exercism and related communication channels and attempt to understand whether someone has deliberately broken the CoC, or accidently crossed a line. We generally reach out to the person who has been reported to discuss any concerns we have and warn them that repeated violations will result in a ban. Sometimes we decide that no violation has occurred and that no action is required and sometimes we will also ban people on a first offence. We strive to be fair, but will err on the side of protecting the culture of our community. | ||
|
||
Exercism's leadership reserve the right to take whatever action they feel appropriate with regards to CoC violations. | ||
|
||
### The simple version | ||
## The simple version | ||
|
||
- Be empathetic | ||
- Be welcoming | ||
|
@@ -23,7 +25,7 @@ Exercism's leadership reserve the right to take whatever action they feel approp | |
- Be supportive | ||
- Be polite | ||
|
||
### The details | ||
## The details | ||
|
||
Exercism should be a safe place for everybody regardless of | ||
- Gender, gender identity or gender expression | ||
|
@@ -72,7 +74,7 @@ If you say something that is found offensive, and you are called out on it, try | |
- Ask for tips / help with avoiding making the offence in the future. | ||
- Apologise and ask forgiveness. | ||
|
||
### History | ||
## History | ||
|
||
This policy was initially adopted from the Front-end London Slack community and has been modified since. A version history can be seen on [GitHub](https://github.com/exercism/website-copy/edit/master/pages/code_of_conduct.md). | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
# Contact Us | ||
|
||
The best place to get help with Exercism is on Github at [https://github.com/exercism/exercism](https://github.com/exercism/exercism). You are welcome to open issues for support requests, ask questions, suggest features, or anything else there. | ||
|
||
If you'd like to get in touch privately please email us at [[email protected]](mailto:[email protected]), but please note that due to the quantity of emails we get we may not reply if the question would be more appropriate on GitHub. | ||
|
||
If you have a Code of Conduct violation to report, please email us at [[email protected]](mailto:[email protected]) and include `[CoC]` in the subject line. We will deal with all CoC issues as a priority. | ||
If you have a Code of Conduct violation to report, please email us at [[email protected]](mailto:[email protected]) and include `[CoC]` in the subject line. We will deal with all CoC issues as a priority. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea why this doesn't work: https://github.com/marketplace/actions/markdownlint-cli
I tried
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried
"analyzer-comments"
or maybe"analyzer-comments/"
?Looking at https://github.com/igorshubovych/markdownlint-cli, it seems like the globbing is used to reference specific files. But the CLI parameter also allows a directory to be ignored (allows file, directory or glob). The README for the link you have given mentions the same.