Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing reference answer of Salary Calculator for consistancy #2875

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

jagdish-15
Copy link
Contributor

@jagdish-15 jagdish-15 commented Nov 26, 2024

pull request

I understand that this change does not significantly impact the outcome of the exercise, but I’ve noticed a small inconsistency that appears in the guidance tab for mentors reviewing this exercise. While it doesn't affect the functionality, these types of inconsistencies can be misleading for mentors. To address this, I am submitting this PR to adjust just two lines and resolve the inconsistency. Thank you for considering the change!


Reviewer Resources:

Track Policies

@jagdish-15
Copy link
Contributor Author

Hi @kahgoh,

I wanted to check if modifying this particular change will affect the answer shown in the Guidance tab during mentoring. Could you please confirm?

Thank you!

@kahgoh kahgoh added the x:size/tiny Tiny amount of work label Nov 26, 2024
Copy link
Member

@kahgoh kahgoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, this solution is shown in the concept tab for the mentoring notes because it is configured as the exemplar solution in the exercise's config.json. I think most of concept exercises (this is a concept exercise) are configured with an exemplar solutions, but not the practice ones.

@kahgoh kahgoh merged commit 1123e5b into exercism:main Nov 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/tiny Tiny amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants