Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix runner crash on some exercises #20

Merged
merged 33 commits into from
Oct 30, 2021
Merged

Fix runner crash on some exercises #20

merged 33 commits into from
Oct 30, 2021

Conversation

NobbZ
Copy link
Member

@NobbZ NobbZ commented Oct 30, 2021

Fix #18
References exercism/erlang#493

NobbZ added 30 commits November 22, 2020 16:06
@NobbZ
add rudimentary flake to use for dev env
61db99f
@NobbZ
Adjust Dockerfile base image
5d0b3bb
@NobbZ
rough first edge
d9ba1cf
@NobbZ
cleaning main
741e1d9
@NobbZ
try some testbaked changes
3b6f047
@NobbZ
add all the test data
425112f
@NobbZ
know that all current practice exercises could be run through the tes…
6e28528 
…t-runner
@NobbZ
prepare for individually running cases
300bc1b
@NobbZ
Merge branch 'main' of github.com:NobbZ/erlang-test-runner
1d63563
@NobbZ
make sure captions are returned as binary
79ee26b
@NobbZ
add a failure in two-fer
269c892
@NobbZ
run the test and grade it
7f03720
@NobbZ
adjust tests
bf0f4a7
@NobbZ
Shuffle tests during run
b8da8cf
@NobbZ
add an assertion for number of failures
af3c3d7
@NobbZ
fallback assertion
c43ab6e
@NobbZ
prepare runner for third argument
a0d34ed
@NobbZ
finish dockerfile
857563a
@NobbZ
fix entrypoint script
1dab6a8
@NobbZ
add config logging during tests
49856b8
@NobbZ
add JSX
413c50b
@NobbZ
write JSON to disk
1e9f64f
@NobbZ
install erl_exercism
9b16256
@NobbZ
run tests in docker
9f87bd7
@NobbZ
extract some common testing helpers
56bd4e5
@NobbZ
use erlsh to run docker
e05a804
@NobbZ
use undefined function to reduce code
0924f9a
@NobbZ
fix casing for docker target names
07d97bb
@NobbZ
Merge branch 'main' of github.com:exercism/erlang-test-runner
897c2ba
@NobbZ
make it accept a list of generators
c7a8fdf
@NobbZ NobbZ requested a review from a team as a code owner October 30, 2021 16:49
@NobbZ NobbZ added hacktoberfest-accepted Make this PR count for hacktoberfest x:action/fix Fix an issue x:knowledge/intermediate Quite a bit of Exercism knowledge required x:module/test-runner Work on Test Runners x:size/small Small amount of work x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises) labels Oct 30, 2021
NobbZ
NobbZ commented Oct 30, 2021
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
iHiD
iHiD approved these changes Oct 30, 2021
View reviewed changes
Copy link
Member

@iHiD iHiD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this so you can merge whenever you're ready, @NobbZ. Thanks for sorting it! :)

@NobbZ NobbZ merged commit cb38b33 into exercism:main Oct 30, 2021
@NobbZ NobbZ deleted the 18-fix-runner-crash branch August 14, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iHiD iHiD iHiD approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Make this PR count for hacktoberfest x:action/fix Fix an issue x:knowledge/intermediate Quite a bit of Exercism knowledge required x:module/test-runner Work on Test Runners x:size/small Small amount of work x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some tests fail for the testrunner in docker, but not when running "live"
2 participants
@NobbZ @iHiD