Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exercises/practice/anagram: add an append with instructions about the order of the return values #706

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IsaacG
Copy link
Member

@IsaacG IsaacG commented Jan 15, 2025

No description provided.

@ryanplusplus
Copy link
Member

Would it make more sense to make the tests more flexible and not enforce an ordering?

@IsaacG
Copy link
Member Author

IsaacG commented Jan 15, 2025

Would it make more sense to make the tests more flexible and not enforce an ordering?

Probably! This PR is intended to communicate the current expectations. Feel free to close this PR if you'd rather leave it vague. Feel free to update the tests to be order-agnostic.

See the forum for the discussion: https://forum.exercism.org/t/14816/

@ryanplusplus
Copy link
Member

Sounds good, I will update the tests when I get a chance.

@meatball133
Copy link
Member

I am questionable about these changes. There are 10 other exercises with the same "problem", that the output order is specific (without any instructions saying it should be). And with these changes: https://github.com/exercism/problem-specifications/pull/2523/files I don't really see any real need for change or an appendum. The exercise could be changed to using sets instead (which would break all current solutions), but I am a bit questionable to other changes.

@IsaacG
Copy link
Member Author

IsaacG commented Jan 16, 2025

Clarify what this track expects. Context: https://forum.exercism.org/t/14816/

@IsaacG
Copy link
Member Author

IsaacG commented Jan 16, 2025

I am questionable about these changes. There are 10 other exercises with the same "problem", that the output order is specific (without any instructions saying it should be). And with these changes: https://github.com/exercism/problem-specifications/pull/2523/files I don't really see any real need for change or an appendum. The exercise could be changed to using sets instead (which would break all current solutions), but I am a bit questionable to other changes.

This PR attempts to clarify what this track requires/expects. Having this clarification is certainly not required! Feel free to close out this PR if you'd prefer not to have this instruction append.

@IsaacG
Copy link
Member Author

IsaacG commented Jan 18, 2025

@meatball133 Given the changes to the spec, would you like to:

  1. merge this PR,
  2. update the tests to change the behavior here, or
  3. close this PR and not specify either way in the instructions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants