Improve the zebra-puzzle. #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ryan Hartlage <[email protected]>
ryanplusplus
reviewed
Mar 2, 2024
| typedef struct { | ||
| const char *drinks_water; | ||
| const char *owns_zebra; | ||
| } solution_t; |
There was a problem hiding this comment.
Can you update the type elsewhere? Now this doesn't match the prototype below or the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion at #959 (comment), this PR changes the API of the solution. Instead of two formally independent functions for the two sub-tasks the tests now require a single function that returns a
structwith the two answers. That should reduce the boilerplate that students will have to write.It also improves some small details of the example solution.